osrd icon indicating copy to clipboard operation
osrd copied to clipboard

core: change interface for pathfinding errors on rolling-stock constraints

Open bougue-pe opened this issue 1 year ago • 1 comments

Full WIP

TODO: fix test

Fix: #7719

bougue-pe avatar Jul 04 '24 16:07 bougue-pe

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.67081% with 44 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (bc3c002) to head (f629528).

Files Patch % Lines
.../api_v2/pathfinding/PathfindingBlocksEndpointV2.kt 83.49% 8 Missing and 9 partials :warning:
...pi/api_v2/pathfinding/PathfindingPostProcessing.kt 38.46% 10 Missing and 6 partials :warning:
...api/api_v2/pathfinding/PathfindingBlockResponse.kt 57.14% 2 Missing and 7 partials :warning:
...r/sncf/osrd/signaling/impl/MockSigSystemManager.kt 0.00% 1 Missing :warning:
...n/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                                  Coverage Diff                                   @@
##             display_pathfinding_constraints_on_shortest_path    #7953      +/-   ##
======================================================================================
+ Coverage                                               27.18%   27.21%   +0.03%     
- Complexity                                               2127     2129       +2     
======================================================================================
  Files                                                    1310     1310              
  Lines                                                  157738   157815      +77     
  Branches                                                 3257     3271      +14     
======================================================================================
+ Hits                                                    42881    42953      +72     
+ Misses                                                 112877   112867      -10     
- Partials                                                 1980     1995      +15     
Flag Coverage Δ
core 75.59% <72.67%> (+0.14%) :arrow_up:
editoast 64.20% <ø> (-0.03%) :arrow_down:
front 10.38% <ø> (ø)
gateway 2.03% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 04 '24 16:07 codecov-commenter