ra2 icon indicating copy to clipboard operation
ra2 copied to clipboard

Added more landing pads to the Airforce Command Center

Open Mailaender opened this issue 5 years ago • 12 comments
trafficstars

Closes https://github.com/OpenRA/ra2/issues/87.

Mailaender avatar Jun 17 '20 18:06 Mailaender

Ok, tested this commit. Some changes need to be done. As you can see in this video:

multiple airfields (see behavior after 30s mark)

When multiple airfields exists, the airplanes sometimes enter in loop trying to find a slot, when another one is open (mostly when building new planes, when coming back from bombing mission, they find the slot correctly)

An possible fix is at build time, find a open slot in all airfields that the player controls and then deploy that plane there.

sorcerer86pt avatar Jun 24 '20 15:06 sorcerer86pt

Your video is not accessible unfortunately.

pgwipeout avatar Jun 24 '20 15:06 pgwipeout

Ok, should be gdrive permissions. I will fix that

A quarta, 24/06/2020, 16:20, Peter Geis [email protected] escreveu:

Your video is not accessible unfortunately.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenRA/ra2/pull/735#issuecomment-648887157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2N4ZYGJFGKAMBIUI73JXLRYIKVRANCNFSM4OA3NARQ .

sorcerer86pt avatar Jun 24 '20 15:06 sorcerer86pt

Try now. Fixed the permissions

sorcerer86pt avatar Jun 24 '20 15:06 sorcerer86pt

An possible fix is at build time, find a open slot in all airfields that the player controls and then deploy that plane there.

Probably not possible with the way this hack works. Only 25% of the pads is constructing aircraft, the others are just for rearming.

Mailaender avatar Jun 24 '20 15:06 Mailaender

May be it needs to spawn/build the plane right on free slot, and without flying/jumping after build?

yaaaaa avatar Jun 24 '20 18:06 yaaaaa

I approve of that.

A quarta, 24/06/2020, 19:54, yaaaaa [email protected] escreveu:

May be it needs to spawn/build the plane right on free slot, and without flying/jumping after build?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenRA/ra2/pull/735#issuecomment-649004190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2N4Z4ERGQFPVY6BREHGB3RYJDXTANCNFSM4OA3NARQ .

sorcerer86pt avatar Jun 24 '20 20:06 sorcerer86pt

Also from the video @sorcerer86pt sent looks like planes land facing 0, they should face 224. https://github.com/MustaphaTR/Romanovs-Vengeance/commit/cc69debf2138312526bcd7c59110544e2a44017b

MustaphaTR avatar Jun 25 '20 04:06 MustaphaTR

Changed the landing facing and added production capabilities to the pads. I don't know why TakeOffOnCreation: false is ignored. We have a ticket for that #683.

Mailaender avatar Jun 25 '20 14:06 Mailaender

SpawnNeighboringActors from a modding perspective (given the information this PR as-is makes available to modders) seems awfully similar to FreeActor, so I believe differentiating via docs/name would be beneficial.

phrohdoh avatar Aug 03 '20 22:08 phrohdoh

Updated and fixed an issue where selling the aircraft command would not remove the additional pads.

Mailaender avatar Aug 08 '20 11:08 Mailaender

Rebased and updated.

Mailaender avatar Dec 13 '20 18:12 Mailaender

Needs rebase.

MustaphaTR avatar Jan 03 '23 17:01 MustaphaTR

Tbh I'm not sure if this PR is necessary. If this repository seems unmaintained to people, I don't think there is a reason to add this workaround, or is there? I.e. since we're not in a rush we can wait for docking to work like we need.

abcdefg30 avatar Jan 03 '23 18:01 abcdefg30