ra2 icon indicating copy to clipboard operation
ra2 copied to clipboard

Backporting Garrison logic from romanovs-vengeance

Open Valkirie opened this issue 4 years ago • 4 comments

Backported all the Garrison logic from romanovs-vengeance, without custom content. Right now, e1 (GI) and e2 (Conscript) can garrison. Should address issue #204.

Author: Devon Dieffenbach (darky) Credit: DnAp (https://github.com/DnAp) - Original PR: OpenRA/OpenRA#12774

TODO:

  • [x] 1:1 backport from Romanovs-vengeance.
  • [ ] Fix the fire animation.
  • [ ] Fix the fire sound.
  • [ ] Don't duplicate traits (AttackGarrisonRV has to be merged with AttackGarrison).

Valkirie avatar Mar 19 '20 12:03 Valkirie

./utility.sh --check-sequence-sprites Tileset: Temperate File not found: true.shp File not found: true.shp File not found: castl04.shp File not found: carus01.shp File not found: cachig04.shp Tileset: Snow File not found: true.shp File not found: true.shp File not found: castl04.shp File not found: carus01.shp File not found: cachig04.shp Tileset: Urban File not found: true.shp File not found: true.shp File not found: castl04.shp File not found: carus01.shp File not found: cachig04.shp

Mailaender avatar Mar 19 '20 13:03 Mailaender

This works surprisingly well in-game. To properly attribute someone elses code: use git commit -m "New Trait - Garrison " --author "Devon Dieffenbach <[email protected]>" on the first commit.

Mailaender avatar Mar 19 '20 13:03 Mailaender

Travis build failed due to :

OpenRA.Utility(1,1): Error: Actor type `cahse01` consumes conditions that are not granted: dmg_crit, chronodisable, build-incomplete
OpenRA.Utility(1,1): Error: Actor type `cahse02` consumes conditions that are not granted: dmg_crit, chronodisable, build-incomplete
OpenRA.Utility(1,1): Error: Actor type `cahse03` consumes conditions that are not granted: dmg_crit, chronodisable, build-incomplete
OpenRA.Utility(1,1): Error: Actor type `cahse04` consumes conditions that are not granted: dmg_crit, chronodisable, build-incomplete
...

sorcerer86pt avatar Mar 19 '20 13:03 sorcerer86pt

Is it fair to say this one is dead?

penev92 avatar Mar 22 '23 19:03 penev92