ra2 icon indicating copy to clipboard operation
ra2 copied to clipboard

Published 20 hours ago • verified publisher icon OpenRA

Setup Chronosphere, Iron Curtain and Weather Control Device animations

Open Mailaender opened this issue 5 years ago • 12 comments

~~Depends on https://github.com/OpenRA/OpenRA/pull/17787.~~

Mailaender avatar Mar 08 '20 19:03 Mailaender

rebase this please

sorcerer86pt avatar Apr 05 '20 12:04 sorcerer86pt

No point in that really as https://github.com/OpenRA/OpenRA/pull/17787 isn't even merged.

Mailaender avatar Apr 05 '20 13:04 Mailaender

HI, the https://github.com/OpenRA/OpenRA/pull/17787 has been merged. I think you can rebase this and retest this

sorcerer86pt avatar May 12 '20 15:05 sorcerer86pt

No, it is still https://github.com/OpenRA/ra2/blob/0bd1e2892b513aabf5a94977e2c850adb848b32c/mod.config#L7

Mailaender avatar May 12 '20 18:05 Mailaender

Rebased

Mailaender avatar Oct 06 '21 19:10 Mailaender

Needs rebase again.

MustaphaTR avatar Jan 03 '23 17:01 MustaphaTR

Had to rebase again due to https://github.com/OpenRA/ra2/pull/806 going in first.

Mailaender avatar Apr 04 '23 17:04 Mailaender

Re using Requires<SupportPowerInfo> - I see that the argument is that we only use that for cases that would crash the game and not cases where otherwise unwanted behaviour would be introduced. That is an upstream convention and while I think it should change I won't hold it against this PR.

penev92 avatar Apr 04 '23 20:04 penev92

I think the main purpose is to modify the initialization order, which is not required in case of these rendering traits which are connected via interfaces.

Mailaender avatar Apr 04 '23 22:04 Mailaender

Here are some polish points to consider:

  • The Weather Control Device's charged animation should freeze when low on power. IMO it would be best to remove the lightnings, not freeze them, but currently nothing happens, which seems pretty weird.
  • The Nuclear Missile Silo's charged and firing animations play on top of the default one, meaning it is clearly visible underneath! Also the missile sprite has lower ZOffset than the Silo's firing sprite, so the missile comes up from behind the structure when firing.
  • The Chronosphere's animations feel like they play too fast (I think we've mentioned this about other building animations as well some time?), but I'll need to compare to the original. The charged animation should also freeze on low power though.
  • The Iron Curtain's animations play too fast. They should also freeze on low power.

If the animation speed is a general mod thing not specific to these structures it can be addressed in a separate PR.

penev92 avatar Apr 04 '23 23:04 penev92

Considering how we currently have the new WithSupportPowerChargedOverlay trait play on top of the regular body/animation/overlay trait(s), wouldn't it be better to instead create a trait that grants a condition on support power charged and have that condition enable an overlay (disabling other rendering traits as needed)? This sounds a bit more generic and reusable.

penev92 avatar Apr 10 '23 13:04 penev92

From my experience, rendering traits work better with interfaces than loosely coupled with conditions.

Mailaender avatar Apr 21 '23 16:04 Mailaender