OpenRAModSDK icon indicating copy to clipboard operation
OpenRAModSDK copied to clipboard

Windows Installer Generation can fail, if mod uses a different version naming scheme than usual.

Open MustaphaTR opened this issue 2 years ago • 0 comments

https://github.com/OpenRA/OpenRAModSDK/blob/master/packaging/windows/buildpackage.sh#L113 seems to switch around the parts of version name before and after the dash, iirc that's because version numbers here needs to start with a number.

My D2k mod do not use the date based version numbering, but a more standard one but starting with a v. So upcoming release would be v2.2, which the code above do not modify and cause an error for not starting with a number. https://github.com/MustaphaTR/MustaphaTR-s-D2K-Mod/actions/runs/6753957395/job/18360972248

While it is kinda my fault not using the date version and i can edit buildpackage.sh locally (i don't want to change versioning scheme at this point), i feel like SDK should be more customisable with this. Perhaps the backwards version should be manually defined somewhere else? Mod.config?

MustaphaTR avatar Nov 04 '23 09:11 MustaphaTR