OpenRAModSDK icon indicating copy to clipboard operation
OpenRAModSDK copied to clipboard

Correct launch-game.cmd join of quoted paths

Open jbfil opened this issue 2 years ago • 2 comments

Unquote strings in launch-game.cmd and quote on use. Now correctly finds directory when there are quotes in the mod.config files.

fixes #175

jbfil avatar Sep 24 '23 00:09 jbfil

The default make all invocation seems to create only the 'engine' directory and not a release tagged version as expected here. Not sure that it would be correct to change this as well.

git diff mod.config
diff --git a/mod.config b/mod.config
index 7c0ab03..f5a0aab 100644
--- a/mod.config
+++ b/mod.config
@@ -9,7 +9,7 @@
 MOD_ID="example"

 # The OpenRA engine version to use for this project.
-ENGINE_VERSION="release-20230225"
+ENGINE_VERSION="engine"

 ##############################################################################
 # Packaging

jbfil avatar Sep 24 '23 17:09 jbfil

It does create it and write the string into the VERSION file for me.

abcdefg30 avatar Sep 25 '23 10:09 abcdefg30