OpenRAModSDK icon indicating copy to clipboard operation
OpenRAModSDK copied to clipboard

Mod display name with special symbols breaks MacOS packaging

Open penev92 opened this issue 2 years ago • 0 comments

First reported by @MustaphaTR and his D2k mod, an investigation concluded that the MacOS packaging script can break if the PACKAGING_DISPLAY_NAME in mod.config contains a '\'' (the mod was called "MustaphaTR's D2k Mod". The Windows installer and Linux AppImages build successfully regardless.

The issue seems to be after https://github.com/OpenRA/OpenRAModSDK/blob/master/packaging/macos/buildpackage.sh#L108 and can likely easily be resolved by escaping input strings.

penev92 avatar Feb 27 '23 20:02 penev92