OpenRA icon indicating copy to clipboard operation
OpenRA copied to clipboard

Published 20 hours ago • verified publisher icon OpenRA

Don't allocate empty sheets

Open PunkPun opened this issue 1 year ago • 4 comments

Currently sheet builder allocates empty BGRA sheets for RA, TD and TS

PunkPun avatar Mar 12 '24 21:03 PunkPun

I measured GPU memory:

  • 95 MiB on bleed
  • 110 MiB on this branch

with nvtop on X11 and Red Alert shell map.

Mailaender avatar Sep 08 '24 14:09 Mailaender

I believe that is from #21557, which is in bleed but this PR hasn't yet rebased to include. Do you get a better result if you rebase the PR and compare?

RoosterDragon avatar Sep 09 '24 17:09 RoosterDragon

95 MiB on bleed 95 MiB on this branch rebased onto bleed

Mailaender avatar Sep 10 '24 20:09 Mailaender

That's great. Since the sheets were empty we never commited anything to the GPU anyway, so I would expect memory to have remained the same.

But this will prevent an empty sheet from being dumped via the utility command, which is a small change but nice to have.

RoosterDragon avatar Sep 11 '24 17:09 RoosterDragon

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/fd100194a0a5395882d4baf85ec2dd33327071aa

pchote avatar Apr 19 '25 10:04 pchote