OpenPrinting
added separate module to handle avahi discovery calls
added a separate module to handle avahi discovery calls. Current PR contains implementation added to ippfind utility only. Planning to add to further places after getting this PR reviewed
This pull request introduces 1 alert when merging 38e8d0fd979a1d71103dc378471d2a66eae83c84 into 803d683ee6ab705fd27c2ab638f666c27d315406 - view on LGTM.com
new alerts:
- 1 for Too few arguments to formatting function
![lgtm-com[bot] avatar](https://avatars.githubusercontent.com/in/17324?v=4 "Published by a pub.dev verified publisher"){kind=small}
Third, only supporting Avahi won't fly. Avahi is what is used on Linux, but mDNSResponder is used on macOS/iOS/Windows and there are plans to add support for the Windows 10+ mDNS/DNS-SD APIs.
I considered this fact while refactoring the code. But to me, it appears that we can not segregate the process of service discovery and resolve in mDNS as we did in avahi implementation. So I considered conditionals for mDNS wherever applicable
Finally, we can't introduce a big change like this for CUPS 2.4.x. It might be appropriate for 2.5 but it feels more like a 3.0 thing - see my libcups project for the work I'm doing towards CUPS 3.0.
That is ok Michael, since this implementation will only be truly useful after optimizing resolve step, which is yet to do.
This pull request introduces 1 alert when merging 2429f1e1b345675430ee6249f1b330fc622f10af into 803d683ee6ab705fd27c2ab638f666c27d315406 - view on LGTM.com
new alerts:
- 1 for Too few arguments to formatting function
This pull request introduces 1 alert when merging 01e8566581e0809bd4395a832f509b10f477ad11 into a2b43e69c7974c9c30186daf9d39e09656fa5925 - view on LGTM.com
new alerts:
- 1 for Too few arguments to formatting function
This pull request introduces 1 alert when merging 43564839a2e9d9bf8c4768acc00e754b1ccc2c54 into 634c8cc2fb004cce8fb34a3aaf38454777605035 - view on LGTM.com
new alerts:
- 1 for Local variable hides global variable
This pull request introduces 1 alert when merging ebec4e3fe0d0fd622487664d07abaf0126d0e336 into 634c8cc2fb004cce8fb34a3aaf38454777605035 - view on LGTM.com
new alerts:
- 1 for Local variable hides global variable
This pull request introduces 1 alert when merging 172985267091a692591bdc3bd5fd4d6e4572a512 into dc8a269ac45c01e6c64aaf6bf6cfa7bfcdbaf445 - view on LGTM.com
new alerts:
- 1 for Local variable hides global variable
Closing. libcups3 has a new API for this, libcups2 will be sticking with the current code.
