cups icon indicating copy to clipboard operation
cups copied to clipboard

update translation for italian

Open luca-vercelli opened this issue 1 year ago • 4 comments

Updated translations for 2.4.x I updated translations on https://hosted.weblate.org/projects/cups/cups/it/, then I downloaded updated .po file. I hope this is the correct workflow. If I am not wrong, translations on Weblate are from 2.4.x, not from master.

luca-vercelli avatar Sep 22 '24 09:09 luca-vercelli

Hi @luca-vercelli ,

thank you for the PR!

AFAIK translations in Weblate are for master branch (and we have to add it into master first, to prevent future regressions) - probably all the new msgids in the end of the PR are for master branch.

Would you mind removing them from this PR? Please do not squash commits, it takes lots of time to review big changes like this, so add your changes as a new commit in your PR.

zdohnal avatar Sep 23 '24 10:09 zdohnal

I removed strings as requested. What should I do about master? Should I provide a new PR with the same (full) file?

luca-vercelli avatar Sep 23 '24 11:09 luca-vercelli

@luca-vercelli I will try to put your commit from 2.4.x into master - it will hopefully take less time than reviewing big MR :D .

zdohnal avatar Sep 24 '24 15:09 zdohnal

Probably you can just cherry-pick my first commit into master. Not the second one.

Il mar 24 set 2024, 17:32 zdohnal @.***> ha scritto:

@luca-vercelli https://github.com/luca-vercelli I will try to put your commit from 2.4.x into master - it will hopefully take less time than reviewing big MR :D .

— Reply to this email directly, view it on GitHub https://github.com/OpenPrinting/cups/pull/1058#issuecomment-2371645115, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLII2GSSMEOHMQQYMNWUHDZYGAXZAVCNFSM6AAAAABOULZKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRGY2DKMJRGU . You are receiving this because you were mentioned.Message ID: @.***>

luca-vercelli avatar Sep 25 '24 02:09 luca-vercelli

Thank you for the PR!

zdohnal avatar Feb 13 '25 12:02 zdohnal