Handling of "air" key in the DNS-SD TXT record looks incorrect

[alexpevzner]

Hi,

According to the specification, the "air" key in the DNS-SD TXT record may take one of the following vales:

• "certificate"
• "negotiate"
• "none"
• "oauth"
• "username,password"

However, TXT record parser at the cups/dest.c file near the line 2811 (function cups_dest_query_cb) contains the following code fragment:

  if (!_cups_strcasecmp(key, "air") && !_cups_strcasecmp(value, "t"))
  {
    type |= CUPS_PTYPE_AUTHENTICATED;
  }

Obviously it does something different that specification requires (I guess it's just a copy-paste of some boolean flag decoder).

It doesn't seem that this issue causes any real problems, but anyway it worth being documenting here...