mapper
mapper copied to clipboard
OpenOrienteering
MapEditorController: Increase size of map notes window
The map notes dialog was quite small and did not automatically adjust itself to the size of the map notes upon creation. This commit defines a minimum and maximum window size and adjusts the size wthin these limits according to the size of the map notes.
Closes #2119
Minimum size (appearance after opening dialog):
Maximum size (appearance after opening dialog):
Sooo seriously, when are we going to get a release that doesn't take a technical degree to install???
Keep making excuses, and keep turning away supporters.
Sent from Proton Mail Android
-------- Original Message -------- On 11/26/24 1:08 AM, Kai Pastor wrote:
@dg0yt commented on this pull request.
Do we want to guard against map == nullptr?
+#include <QScreen> +#include <QSize> +#include <QTextEdit> +#include <QVBoxLayout> +#include <QWidget>
+#include "core/map.h" + + +namespace OpenOrienteering { + +MapNotesDialog::MapNotesDialog(QWidget* parent, Map* map) +: QDialog(parent, Qt::WindowSystemMenuHint | Qt::WindowTitleHint | Qt::WindowCloseButtonHint) +, map { map } +{
- setWindowTitle(QCoreApplication::translate("OpenOrienteering::MapNotes", "Map notes"));
Either
⬇️ Suggested change
- setWindowTitle(QCoreApplication::translate("OpenOrienteering::MapNotes", "Map notes"));
- setWindowTitle(QCoreApplication::translate("OpenOrienteering::MapEditorController", "Map notes"));
or
⬇️ Suggested change
- setWindowTitle(QCoreApplication::translate("OpenOrienteering::MapNotes", "Map notes"));
- setWindowTitle(tr("Map notes"));
- width = qMax(300, qMin(width, bounding_rect.width() + 60));
- height = qMax(200, qMin(height, bounding_rect.height() + 80));
⬇️ Suggested change
- width = qMax(300, qMin(width, bounding_rect.width() + 60));
- height = qMax(200, qMin(height, bounding_rect.height() + 80));
- width = qBound(300, width, bounding_rect.width() + 60);
- height = qBound(200, height, bounding_rect.height() + 80);
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>
Yes, I've tried to follow the documentation to install openorienteering a few times and failed. Is the documentation out of date? I only see the same few people create commits here. This doesn't seem like an Open architecture since it's been several, several years since updating the main core.
Sent from Proton Mail Android
-------- Original Message -------- On 11/26/24 2:06 AM, Kai Pastor wrote:
Take a technical degree to install???
Be careful. Humans on both sides.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
Let me reiterate, I've tried to install the GIT version of Openorienteering so I could maybe add some input. Tried, and tried again.
From an outsider it seems like there's just a select few of people that can contribute.
Just make a new release ...
Sent from Proton Mail Android
-------- Original Message -------- On 11/26/24 2:19 AM, wrote:
Yes, I've tried to follow the documentation to install openorienteering a few times and failed. Is the documentation out of date? I only see the same few people create commits here. This doesn't seem like an Open architecture since it's been several, several years since updating the main core.
Sent from Proton Mail Android
-------- Original Message -------- On 11/26/24 2:06 AM, Kai Pastor wrote:
Take a technical degree to install???
Be careful. Humans on both sides.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
Let me reiterate, I've tried to install the GIT version of Openorienteering so I could maybe add some input. Tried, and tried again.
Let me reiterate:
If you want to ask for help with building from source, open an issue or discussion.
If you want to not slow down things, kindly avoid rants on unrelated issues and PRs.
You're slowing things down.
Sent from Proton Mail Android
-------- Original Message -------- On 11/26/24 2:40 AM, Kai Pastor wrote:
Let me reiterate, I've tried to install the GIT version of Openorienteering so I could maybe add some input. Tried, and tried again.
Let me reiterate: If you want to ask for help with building from source, open an issue or discussion. If you want to not slow down things, kindly avoid rants on unrelated issues and PRs.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
@PappyEric Sorry, I have to put you on my block list. Toxic discussion are not beneficial.
@PappyEric No matter how much I understand your position and why you are discussing your issue right here, please mind that discussion is off-topic in the context of this code pull request. The Discussions place might be a better home for conversations about the project leadership, perhaps with a more articulated set of reproaches and honors towards the OO developers team. Thanks!
@PappyEric No matter how much I understand your position and why you are discussing your issue right here, please mind that discussion is off-topic in the context of this code pull request. The Discussions place might be a better home for conversations about the project leadership, perhaps with a more articulated set of reproaches and honors towards the OO developers team. Thanks!
Sorry
Shall I keep three commits (I would split the 4th one and squash appropriately) or shall I squash and update the commit message?
I would squash the PR with the merge. Unless you want control over the commit message :smile:
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}