mapper icon indicating copy to clipboard operation
mapper copied to clipboard

Build tests fail with archlinux

Open ratzupaltuff opened this issue 3 years ago • 3 comments

Steps to reproduce

  1. Update Arch AUR File to Version 0.9.5 and correct hash
# Maintainer: tufftuff <xyf aat posteo doot net>
# Contributor: Nikolay Korotkiy <[email protected]>
_orgname=OpenOrienteering
_pkgname=mapper
pkgname=${_orgname,,}-${_pkgname}
pkgver=0.9.5
pkgrel=1
pkgdesc='Map drawing program from OpenOrienteering'
arch=(x86_64)
url='https://www.openorienteering.org/apps/mapper/'
license=('GPL3')
depends=('qt5-base>=5.5' 'polyclipping>=6.1.3a' 'proj>=4.9' 'gdal>=2')
makedepends=('cmake>=3.7' 'qt5-tools>=5.5' 'doxygen' 'libcups')
checkdepends=('qt5-imageformats')
optdepends=('qt5-imageformats: Support for TIFF etc.'
            'qt5-translations: for Qt5 dialog translations')
provides=("${pkgname}=${pkgver}")
conflicts=(${pkgname}-git)
install=${pkgname}.install
source=("https://github.com/${_orgname}/${_pkgname}/archive/v${pkgver}.tar.gz")
sha256sums=('619152ca01a370875c15e1930918ce961284ccbf5d2371c147d50caf5e5c2f00')

build() {
  cd ${_pkgname}-${pkgver}

  rm -rf build
  mkdir -p build
  cd build

  cmake ..                      \
    -DCMAKE_BUILD_TYPE=Release  \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DLICENSING_PROVIDER=arch   \
    -DMapper_PACKAGE_NAME=${pkgname} \
    -Wno-dev
  cmake --build .
}

check() {
  cd ${_pkgname}-${pkgver}/build

  cmake --build . --target test
}

package() {
  cd ${_pkgname}-${pkgver}/build

  DESTDIR=${pkgdir}/ cmake --build . --target install
}
  1. run makepkg

Actual behaviour

Test Errors prevent successful build The Build fails with the Test-Errors:

23/28 Testing: template_t
23/28 Test: template_t
Command: "/usr/bin/cmake" "-P" "template_t-RUN.cmake"
Directory: /home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/build/test
"template_t" start time: Nov 08 00:25 CET
Output:
----------------------------------------------------------
********* Start testing of TemplateTest *********
Config: Using QtTest library 5.15.7, Qt 5.15.7 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), arch unknown
PASS   : TemplateTest::initTestCase()
PASS   : TemplateTest::gdalUtilTest()
PASS   : TemplateTest::worldFilePathTest()
PASS   : TemplateTest::worldFileUnitTest()
PASS   : TemplateTest::worldFileTemplateTest()
PASS   : TemplateTest::templatePathTest()
PASS   : TemplateTest::templateImageDrawableTest()
ERROR 4: гео.tiff: No such file or directory
PASS   : TemplateTest::geoTiffTemplateTest()
PASS   : TemplateTest::geoTiffSRSTest()
PASS   : TemplateTest::templateTrackTest(TemplateTrack georef)
PASS   : TemplateTest::templateTrackTest(TemplateTrack non-georef)
PASS   : TemplateTest::templateTrackTest(TemplateTrack OGR georef)
PASS   : TemplateTest::templateTrackTest(TemplateTrack OGR non-georef)
FAIL!  : TemplateTest::templateTrackTest(TemplateTrack NAD83) Compared values are not the same
   Actual   (center(temp))   : QPointF(-154.599,172.28)
   Expected (expected_center): QPointF(-154.274,172.377)
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(456)]
FAIL!  : TemplateTest::templateTrackTest(OgrTemplate NAD83) Compared values are not the same
   Actual   (center(temp))   : QPointF(-154.599,172.28)
   Expected (expected_center): QPointF(-154.274,172.377)
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(456)]
XPASS  : TemplateTest::templateTrackTest(TemplateTrack from v0.8.4) 'true' returned TRUE unexpectedly. (Centers do match)
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(458)]
FAIL!  : TemplateTest::templateTrackTest(TemplateTrack from v0.9.3) Compared values are not the same
   Actual   (center(temp))   : QPointF(-154.599,172.28)
   Expected (expected_center): QPointF(-154.36,172.429)
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(456)]
Warning 1: +init=epsg:XXXX syntax is deprecated. It might return a CRS with a non-EPSG compliant axis order.
PASS   : TemplateTest::ogrTemplateTest(TemplateTrack georef)
PASS   : TemplateTest::ogrTemplateTest(TemplateTrack non-georef)
PASS   : TemplateTest::ogrTemplateTest(TemplateTrack OGR georef)
PASS   : TemplateTest::ogrTemplateTest(TemplateTrack OGR non-georef)
PASS   : TemplateTest::ogrTemplateTest(OgrTemplate basic)
PASS   : TemplateTest::ogrTemplateTest(OgrTemplate compatibility)
XFAIL  : TemplateTest::ogrTemplateTest(TemplateTrack NAD83) Unsupported WGS 84 -> NAD 83 transformation
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(501)]
PASS   : TemplateTest::ogrTemplateTest(TemplateTrack NAD83)
XFAIL  : TemplateTest::ogrTemplateTest(OgrTemplate NAD83) Unsupported WGS 84 -> NAD 83 transformation
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(501)]
PASS   : TemplateTest::ogrTemplateTest(OgrTemplate NAD83)
ERROR 4: template-track-NA-2019.gpx: No such file or directory
PASS   : TemplateTest::ogrTemplateTest(TemplateTrack from v0.8.4)
PASS   : TemplateTest::ogrTemplateTest(OGRTemplate from v0.9.3)
PASS   : TemplateTest::ogrTemplateGeoreferencingTest()
PASS   : TemplateTest::templateTypesConsistentTest(TemplateTrack georef)
PASS   : TemplateTest::templateTypesConsistentTest(OgrTemplate georef)
XPASS  : TemplateTest::templateTypesConsistentTest(TemplateTrack NAD83) 'true' returned TRUE unexpectedly. (Centers do match)
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(577)]
XPASS  : TemplateTest::templateTypesConsistentTest(OgrTemplate NAD83) 'true' returned TRUE unexpectedly. (Centers do match)
   Loc: [/home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/test/template_t.cpp(577)]
PASS   : TemplateTest::templateRotationTest(TemplateImage world file)
PASS   : TemplateTest::templateRotationTest(TemplateTrack georef)
PASS   : TemplateTest::templateRotationTest(TemplateTrack non-georef)
ERROR 4: гео.tiff: No such file or directory
PASS   : TemplateTest::templateRotationTest(GdalImage geotiff)
PASS   : TemplateTest::templateRotationTest(OgrTemplate basic)
PASS   : TemplateTest::templateRotationTest(OgrTemplate compatibility)
PASS   : TemplateTest::asyncLoadingTest(TemplateImage)
PASS   : TemplateTest::asyncLoadingTest(TemplateTrack georef)
PASS   : TemplateTest::asyncLoadingTest(TemplateTrack non-georef)
PASS   : TemplateTest::asyncLoadingTest(OgrTemplate basic)
PASS   : TemplateTest::asyncLoadingTest(OgrTemplate compatibility)
PASS   : TemplateTest::templateTableModelTest()
PASS   : TemplateTest::cleanupTestCase()
Totals: 39 passed, 6 failed, 0 skipped, 0 blacklisted, 7115ms
********* Finished testing of TemplateTest *********
CMake Error at template_t-RUN.cmake:35 (message):
  Test template_t failed: 6


<end of output>
Test time =   7.16 sec
----------------------------------------------------------
Test Failed.
"template_t" end time: Nov 08 00:25 CET
"template_t" time elapsed: 00:00:07

and

24/28 Testing: tools_t
24/28 Test: tools_t
Command: "/usr/bin/cmake" "-P" "tools_t-RUN.cmake"
Directory: /home/tuff/.cache/yay/openorienteering-mapper/src/mapper-0.9.5/build/test
"tools_t" start time: Nov 08 00:25 CET
Output:
----------------------------------------------------------
********* Start testing of ToolsTest *********
Config: Using QtTest library 5.15.7, Qt 5.15.7 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), arch unknown
PASS   : ToolsTest::initTestCase()

=== Received signal at function time: 7ms, total time: 58ms, dumping stack ===
GNU gdb (GDB) 12.1
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
Attaching to process 178384
(gdb) === End of stack trace ===
QFATAL : ToolsTest::editTool() Received signal 11
         Function time: 7ms Total time: 58ms
FAIL!  : ToolsTest::editTool() Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted, 162ms
********* Finished testing of ToolsTest *********
CMake Error at tools_t-RUN.cmake:35 (message):
  Test tools_t failed: Subprocess aborted


<end of output>
Test time =   0.38 sec
----------------------------------------------------------
Test Failed.
"tools_t" end time: Nov 08 00:25 CET
"tools_t" time elapsed: 00:00:00

Expected behaviour

The two tests should pass

Configuration

Mapper Version: 0.9.5 Operating System: Archlinux with Kernel 6.0.7-arch1-1 x86

Are There any build changes or dependencies I am missing?

ratzupaltuff avatar Nov 08 '22 12:11 ratzupaltuff

I tried your updated AUR file on Arch Linux. The results were:;

  • At first the build failed due to the GDAL license having moved. I worked around that problem.
  • Reproduced the <template_t> failure.
  • <tools_t> test was successful.

The license problem is the subject of PR #2089, which has been merged to the master branch on GitHub as commit 72ea2139 Licensing: Find GDAL license on Arch Linux

The <template_t> failure is the subject of issue #2008, addressed by PR #2024. The PR is merged to the master branch in GitHub as commit 40cddb15 Georeferencing: Choose transformations without restricting authority
A change in PROJ 8.2 led to this problem.

Mapper 0.9.5 is the latest release and does not have these fixes.

pkturner avatar Nov 10 '22 18:11 pkturner

Mapper 0.9.5 is the latest release and does not have these fixes.

AUR packages built on OBS:

  • https://software.opensuse.org/download.html?project=home%3Adg0yt&package=openorienteering-mapper-unstable
    • https://download.opensuse.org/repositories/home:/dg0yt/Arch_Community/x86_64/

ghost avatar Nov 11 '22 03:11 ghost

Thank you @pkturner.

I checked OBS when you opened the issue, but I had to learn that the Arch build fails there, too. I will try to fix this.

dg0yt avatar Nov 11 '22 07:11 dg0yt