mapper icon indicating copy to clipboard operation
mapper copied to clipboard

Handle secondary symbols for OCD line symbols

Open dg0yt opened this issue 4 years ago • 4 comments

OCD secondary symbols are placed in the middle between regular mid symbols. Mapper doesn't have explicit secondary symbols, so this must be implemented via a combined symbol. ~For test data such as MTBO symbol 711 Forbidden route, it turned out that the secondary symbol also needs to be mirrored.~

No export yet. Feedback and contributions welcome.

dg0yt avatar May 20 '21 05:05 dg0yt

Task: GH-1951

dg0yt avatar May 20 '21 06:05 dg0yt

For test data such as MTBO symbol 711 Forbidden route, it turned out that the secondary symbol also needs to be mirrored.

Actually, no. I'm afraid we just never imported the secondary symbol correctly because we never passed the right offset to setupPointSymbolPattern. :roll_eyes:

dg0yt avatar May 20 '21 06:05 dg0yt

I tried to break none of the existing reconstructions of line symbols (framing, double line). But I didn't test with many OCD files.

dg0yt avatar May 21 '21 07:05 dg0yt

We might add a similar convenience symbol to our symbol sets. This should expose the new code paths to automated testing.

dg0yt avatar May 21 '21 10:05 dg0yt