open-numismat icon indicating copy to clipboard operation
open-numismat copied to clipboard

Support for metal detecting

Open PhilPJL opened this issue 1 year ago • 7 comments

The app supports latitude and longitude, so I just need a flag to indicate the coin was found. I've added a tag:

image

Is it possible to show this value in the grid?

PhilPJL avatar Jan 05 '25 15:01 PhilPJL

First let me say that I'm not the author of the program.

Isn't it better to add a new State - "Found". Possibly some parameters in the Market section will have to be removed such as the prices, the commission, the seller. And statistics and reports will have to be corrected.

In general, status names can be edited, but I don't think it's a good solution in this case.

NEKolev avatar Jan 05 '25 21:01 NEKolev

I like your idea of a new state. Then either modify the 'buy' section, or replace it with a 'find details' section which could have date, lat/long (same as map), place, info.

PhilPJL avatar Jan 05 '25 22:01 PhilPJL

While digging into the other issue I noticed that they have a nomenclature for "Method of discovery", which in this case might be useful to add in the possible new Status. https://finds.org.uk/database/artefacts/record/id/1191543#:~:text=Method%20of%20discovery%3A%20Metal%20detector

Unfortunately, it was difficult to manually see the other options except "Metal detector". I tried it with changing the ID, but there must be many. https://finds.org.uk/datalabs/terminology/method/id/1/format/json

NEKolev avatar Jan 05 '25 22:01 NEKolev

https://finds.org.uk/datalabs/terminology/methods

PhilPJL avatar Jan 05 '25 22:01 PhilPJL

Status is not very good because when you sell this coin and change the status you will lose the information.

May be better place is a new field near Status: image or (for my taste it is preferable) in Market tab (Market and Buy labels can be renamed by user itself): image

Also duplicating lat/long on Market tab is not a good idea. But I don't lose hope that soon there will be an editor for this dialog and it will be possible to place it anywhere

Another value for this field - Present. It should enable fields Date, Info, Seller (Donor)

JanisV avatar Jan 10 '25 15:01 JanisV

And one more idea: https://github.com/OpenNumismat/open-numismat/issues/109 (Remarks field on the map tab).

JanisV avatar Jan 10 '25 15:01 JanisV

Maybe you should consider not saving the first Status and losing the history at the moment as well, because it applies to the other statuses that exist now. Maybe in some intermediate table or something.

It is useful to be able to pull up a report for example: Found on 1.1.2025 -> Sold on 1.10.2025

Of course, this is perhaps a very big change in the current logic.

NEKolev avatar Jan 10 '25 16:01 NEKolev