autoEdit_2
autoEdit_2 copied to clipboard
Tweet that clip
PR for new feature https://github.com/OpenNewsLabs/autoEdit_2/issues/74
To test before merge
- [x] Tweet video as audio with captions
- [x] Tweet video as audio without captions <-- Not working
- [x] Tweet video as video with captions
- [x] Tweet video as video without captions <-- Not working
Also check
- [ ] What happens if you start tweeting a new clip when another one is still being processed? (should work 🤞 but it might not - tbc)
Tweeting video does not seem to work
To do:
- [x] update with master
- [ ] ~What happens if you start tweeting a new clip when another one is still being processed? (should work 🤞 but it might not - tbc)~
Does not seem to apply as the button is disabled until the tweet has confirmed to have gone through
Tested and seems to work fine
Tested after latest change that makes captions optional.
- [x] Tweet video as audio with captions
- [x] Tweet video as audio without captions
- [x] Tweet video as video with captions
- [x] Tweet video as video without captions
Some things to think about
- [ ] Twitter credentials
To tweet clips to twitter, twitter credentials are required. And in the current setup the user needs to create a twitter app, in quickQuoteNode
which used express, user could just log in with their twitter account using passport.js
The problem is that the app to tweet on user's behalf requires
-
Twitter Consumer Key
-
Twitter Consumer Secret
-
Twitter Access Token
-
Twitter Access Token Secret
As far as I understood it, the first two, are part of creating a twitter app, with twitter authentication, while the second two are user specific, and the once that where taken through passportJS in quickQuoteNode express example mentioned above.
- [ ] The UI for selecting a clip segment might be confusing.
Using set in and /set out might not be as straight forward as it could be. Eg it could be connected with selections / highlight instead?
Some stuff left to do
- [ ] add, "How To" to user manual
- [ ] update user manual version number to latest version
1.0.19
- [ ] add instructions how to get Twitter credentials for settings
Leaving a note that with Firebase auth, firebase.auth.TwitterAuthProvider
you can do this and get token and secret
// Using a redirect.
firebase.auth().getRedirectResult().then(function(result) {
if (result.credential) {
// For accessing the Twitter API.
var token = result.credential.accessToken;
var secret = result.credential.secret;
}
var user = result.user;
});
// Start a sign in process for an unauthenticated user.
var provider = new firebase.auth.TwitterAuthProvider();
firebase.auth().signInWithRedirect(provider);