openneuro icon indicating copy to clipboard operation
openneuro copied to clipboard

feat: Pass custom config to validator

Open effigies opened this issue 1 year ago • 2 comments

In prep to migrate to the schema validator, we need to promote some warnings to errors.

Reminded that we need to do this by bids-standard/bids-specification#1928, which proposes to downgrade SUBJECT_FOLDERS from an error to a warning. I don't think OpenNeuro wants to downgrade that, so this preemptively pegs it as an error.

effigies avatar Oct 25 '24 18:10 effigies

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 44.06%. Comparing base (1c1e0d3) to head (10877ad). Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
...openneuro-app/src/scripts/workers/schema.worker.ts 0.00% 15 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3184      +/-   ##
==========================================
+ Coverage   43.10%   44.06%   +0.95%     
==========================================
  Files         547      547              
  Lines       36178    36192      +14     
  Branches     1128     1162      +34     
==========================================
+ Hits        15595    15947     +352     
+ Misses      20383    20056     -327     
+ Partials      200      189      -11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 25 '24 18:10 codecov[bot]

xref https://github.com/bids-standard/bids-validator/pull/2176, since that's needed to support microscopy blacklisting properly.

effigies avatar Oct 26 '24 02:10 effigies

Included in #3206

nellh avatar Nov 12 '24 22:11 nellh