openneuro icon indicating copy to clipboard operation
openneuro copied to clipboard

Datasets may fail to save validation due to hedIssues field on ValidationIssueFileInput

Open nellh opened this issue 1 year ago • 3 comments

What went wrong?

If hedIssues fields for files are returned by the legacy validator, this is not allowed by the OpenNeuro issue format and these datasets will fail to validate. The parameters field on this field doesn't look well typed, so we either need to filter that or specify it can be any object.

Expected behavior

hedIssues datasets should not fail to validate.

How to reproduce

No response

Desktop

  • OS:
  • Browser:
  • Version:

Phone

  • Device:
  • OS:
  • Browser:
  • Version:

Additional information

No response

nellh avatar Sep 27 '24 20:09 nellh

Thanks very much, @nellh, Please let me know if there is anything we can do wrt HED.

neuromechanist avatar Sep 30 '24 01:09 neuromechanist

@neuromechanist @nellh This should be fixed by https://github.com/bids-standard/bids-validator/pull/2143

VisLab avatar Oct 01 '24 10:10 VisLab

Confirming that does fix the issue, I'll close this once it's merged for an OpenNeuro release.

nellh avatar Oct 02 '24 19:10 nellh