openneuro icon indicating copy to clipboard operation
openneuro copied to clipboard

bump NiiVue to latest version (0.43.3)

Open hanayik opened this issue 1 year ago • 2 comments

This PR bumps the version of NiiVue to the latest version available on NPM at the time of this writing. Using the latest version of niivue was also mentioned in #3001.

changes

  • increment @niivue/niivue package version number to 0.43.3

notes

  • There should not be any functional changes. The package in version 0.43.3 is much smaller compared to the older version being used in OpenNeuro.
  • Niivue is also written in TypeScript now, so types are included in the package.
  • There may be slight performance improvements by using the latest version of NiiVue.

hanayik avatar May 20 '24 10:05 hanayik

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.53%. Comparing base (e6c532f) to head (7f22fce). Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3056       +/-   ##
===========================================
+ Coverage   44.03%   65.53%   +21.50%     
===========================================
  Files         593       56      -537     
  Lines       37807     2356    -35451     
  Branches     1125       34     -1091     
===========================================
- Hits        16647     1544    -15103     
+ Misses      20958      812    -20146     
+ Partials      202        0      -202     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 11:05 codecov[bot]

⎯⎯⎯⎯⎯⎯ Failed Suites 2 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  packages/openneuro-app/src/scripts/dataset/__tests__/snapshot-container.spec.tsx [ packages/openneuro-app/src/scripts/dataset/__tests__/snapshot-container.spec.tsx ]
 FAIL  packages/openneuro-app/src/scripts/dataset/files/__tests__/file-viewer-type.spec.jsx [ packages/openneuro-app/src/scripts/dataset/files/__tests__/file-viewer-type.spec.jsx ]
SyntaxError: Named export 'Decompress' not found. The requested module 'fflate/browser' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fflate/browser';
const { Decompress, decompressSync: decompressSync3, gzipSync } = pkg;

 ❯ packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx:3:31
      1| import React, { useEffect, useRef } from "react"
      2| import PropTypes from "prop-types"
      3| import { Niivue } from "@niivue/niivue"
       |                               ^
      4| 
      5| const FileViewerNifti = ({


Error: SyntaxError: Named export 'Decompress' not found. The requested module 'fflate/browser' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fflate/browser';
const { Decompress, decompressSync: decompressSync3, gzipSync } = pkg;

 ❯ packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx:3:31


⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯


Error: SyntaxError: Named export 'Decompress' not found. The requested module 'fflate/browser' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fflate/browser';
const { Decompress, decompressSync: decompressSync3, gzipSync } = pkg;

 ❯ packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx:3:31

effigies avatar May 20 '24 19:05 effigies

Superseded by #3168

nellh avatar Oct 02 '24 22:10 nellh