[FSunstone] Dialog reviews

Open vichansson opened this issue 1 year ago • 0 comments

Description

Size reviews & overall improvements and notices

The following tabs have been reviewed:

Instances:
- VMs
  - Backup dialog redesign
- Virtual Routers
- Services
Templates:
- VM Templates
- Service Templates
- Virtual Routers
- VM Groups
Storage:
- Datastores
- Images
- Files
- Marketplaces
- Apps
- BackupJobs
Networks:
- Virtual Networks
- Network Templates
- Security Groups
Infrastructure:
- Clusters
- Hosts
- Zones
System
- Users
- Groups
- VDCs
- ACLs
Settings

[!NOTE]
Need to fix anchor points in common annotations for easier navigation

add captions to all images

fix typos & indentation

Common Annotations

Lists issues / ideas that appear in more places than one for easier referencing

Schedule Actions Tab needs refactoring - Does not make very well use of all the available page size + charter dialog needs redesign

Schedule Actions Tab

Charter Dialog

Suggestions
- Responsive design, display a minimum width*height of 2 charter elements (scheduled actions), scaling up to some appropriate max value, after which elements should overflow vertically
- Add charter config to either redux persistent store or under the user templates FIREEDGE attribute, for persistent storage and more fine-grained control.
OS Booting displaying no content - Should display some placeholder/help message even if no content is to be displayed

OS Booting Tab
Lock/Unlock dialog max/min width - Dialog looks a little small, should have a min width + max width set, and instead of scaling it horizontally, we want to list all items vertically, one per row

Lock Dialog Single selected

Lock Dialog Multiple selected
Dialog is too wide - Change number of columns depending on viewport width thus reducing blank space

VM Host Deploy dialog
Share dialog too wide - should have a max width set + fix text formatting

Share dialog
Delete dialog rework - Update text + list which items are being deleted with the possibility to remove/deselect individual items separately inside the dialog - Redesign Delete dialog templates

Delete dialog
Custom Variables - Could do with some sort of helper text potentially

Custom Variables step
Clone dialog rework - Too large in single select mode + does not display which templates have been selected for cloning. Should have separate input fields for every template, making it possible to customize each cloning operation's naming. Same idea/concept as in CA.6 VM Templates clone dialog

Instances

VMs

Instantiate
- Selection dialog => CA.4
- Stepper/Advanced options/Schedule Action => CA.1
- Stepper/Advanced options/Booting => CA.2
Manage
- [Suspend, Stop, Poweroff, Poweroff Hard, Reboot, Reboot Hard, Undeploy, Undeploy Hard] => OK
Host
- Deploy => CA.4
- [Migrate, Migrate Live] => OK
- [Hold, Release] => Update dialog text depending on VM state
- [Reschedule, Un-Reschedule] => OK
- Recover => Dialog too big, not making use of the available space. Instead of hiding the operation help text in a bubble next to the input field, list it underneath the operation selector dropdown so it's always visible. Also move the names of the selected VM's from up top, to bottom in a table like view, with the added option to deselect VM's from the operation - Redesign
- Backup => A reset switch does not need a full separate step - Redesign
Ownership
- [Change Owner, Change Group] => OK
Lock
- Lock/Unlock => OK
Terminate
- [Terminate, Terminate Hard] => OK
Save as Template => Unnecessarily large, 1 input field + 1 checkbox can be made a lot more compact - Redesign
Create Marketplace App => OK
Attack Disk/Image => OK
Attach NIC => OK
Take snapshot => Unnecessarily large, 1 input field does not need to have a dialog of this size - Redesign
Sched Actions tab - "Add action" => CA.1
Configuration tab - "Update VM Configuration" => OK

Virtual Routers

Instantiate => OK
Ownership
- [Change Owner, Change Group] => OK
Lock
- [Lock, Unlock] => CA.3
Delete => OK - Could display more details when deleting multiple

VR Delete Multiple dialog

Services

Instantiate
- Selection dialog => CA.4
- Stepper/Charter => CA.1
Ownership
- [Change Owner, Change Group] => OK
Recover
- Recover Service => Missing recover --delete option, should be a switch in the dialog itself
- Recover Delete => Update text, currently shows the same text as Recover Service
Delete => CA.6

Templates

VM Templates

Create
- Stepper/General => Mostly OK, layout could do with an update, some fields are just randomly scattered around - Redesign
- Stepper/Advanced options/Storage => Potentially move things around a bit as the "Attach disk" dropdown currently looks a bit out of place - Redesign
- Stepper/Advanced options/Network => Same layout problem as with the Stepper/Advanced options/Storage tab - Redesign
- Stepper/Advanced options/[OS & CPU, Context] => Layout needs some work - Redesign
- Stepper/Advanced options/Schedule Action => CA.1
- Stepper/Advanced options/Placement => WIP - OpenNebula/one#6419
- Stepper/Advanced options/NUMA => Display all fields by default, makes poor use of the available space - Redesign
  
  NUMA tab
  
  Expanded NUMA tab
- Stepper/Custom Variables => CA.7
Instantiate => Same as the Create step mostly
- Stepper/Advanced Options/OS Booting => CA.2
Create Marketplace App => OK
Update => Same as instantiate/create dialog
Clone => CA.8
Ownership
- [Change Owner, Change Group] => OK
- [Share, Unshare] => CA.5
Lock
- [Lock, Unlock] => CA.3
Delete => CA.6

Service Templates

Create => OK
Instantiate
- Same as Templates/VM Templates/Instantiate
- Stepper/Charter => CA.1
Update => OK
Ownership
- [Change Owner, Change Group] => OK
Delete => Fix text + set a min width & same idea/concept as in CA.6

Virtual Routers

Create => Same as Templates/VM Templates/Create
Instantiate => OK - Maybe skip rendering the User Inputs step if VR has no user inputs
Update => Same as create
Clone => CA.8
Ownership
- [Change Owner, Change Group] => OK
- [Share, Unshare] => CA.5
Lock
- [Lock, Unlock] => CA.3
Delete => CA.6

VM Groups

Create => OK
Update => OK
Enable/Disable => OK
Delete => CA.6

Storage

Datastores

Create
- Stepper/Custom Variables => CA.7
Select Cluster => OK
Enable
- [Enable/Disable] => Same problem as in CA.3
Ownership
- [Change Owner, Change Group] => OK
Delete => CA.6

Images

Create => Redundant "extra" dialog is opened after you press the "Create" button, should directly go to creation dialog instead

Redundant create dialog
- Stepper/Custom Attributes => CA.7
Clone => Wrong title on dialog + should display individual input fields for every item for better name customization & input fields take up full width

Image Clone dialog
Lock
- [Lock, Unlock] => CA.3
Ownership
- [Change Owner, Change Group] => OK
Delete => CA.6

Files

Create => OK overall, make upload popup wider + display filename File upload progress indicator
Lock
- [Lock, Unlock] => CA.3
Ownership
- [Change Owner, Change Group] => OK
- [Share, Unshare] => CA.5
Delete => CA.6

Marketplaces

Create => OK
Update => OK
Enable
- [Enable/Disable] => Same problem as in CA.3
Delete => CA.6

Apps

Create => OK
Download App to OpenNebula => OK
Lock
- [Lock, Unlock] => CA.3
Enable
- [Enable/Disable] => Same problem as in CA.3
Ownership
- [Change Owner, Change Group] => OK
- [Share, Unshare] => CA.5
Delete => CA.6

BackupJobs

Create
- Stepper/Select Datastores => Displays no options if you don't have a backup DS defined
- Stepper/Schedule action => CA.1
Start => Make dialog a bit wider & refactor text a bit

BackupJob Start dialog
Cancel => Same thing as with the Start dialog
Ownership
- [Change Owner, Change Group] => OK
Lock
- [Lock, Unlock] => CA.3
Delete => CA.6

Networks

Virtual Networks

Create => OK
Instantiate => BUG! Instantiate button is disabled unless you select an existing VNET
- Same problem as in CA.4. Make responsive to the number of columns.
Update => OK
Reserve => Lots of blank space - Redesign

Virtual Networks Reservation dialog
Select Cluster => OK
Ownership
- [Change Owner, Change Group] => OK
Lock
- [Lock, Unlock] => CA.3
Delete => CA.6

Network Templates

Create => BUG! Yup schema does not set "VM_MAD" as required, otherwise OK
Instantiate
- Selection Dialog => CA.4
- Stepper/Configuration => Looks very empty? Can be reworked? - Redesign Network Template Instantiation dialog
Update => Same as Create dialog
Ownership
- [Change Owner, Change Group] => OK
Lock
- [Lock, Unlock] => CA.3
Delete => CA.6

Security Groups

Create => OK!
Update => OK!
Clone => CA.8
Commit => Dialog is too big, needs to be made smaller

Security Groups Commit dialog
Ownership
- [Change Owner, Change Group] => OK
Delete => CA.7

Infrastructure

Clusters

Create => OK
Update => OK
Delete => CA.6

Hosts

Create => OK
Select Cluster => OK
Enable/Disable => OK
Delete => CA.6

Zones

=> OK! No dialogs!

System

Users

Create => OK
Delete => CA.6
Enable/Disable => OK

Groups

Create
- Stepper/Permissions => Could do with a layout update - Redesign
- Stepper/System => Merge this step with another one? Redundant? Groups Creation Dialog System step
Update => OK - Same as Create dialog
Delete => CA.6
Edit Adminstrators => OK

VDCs

Create => Overall OK - last step same issue as in CA.6
Update => Same as Create dialog
Delete => CA.6

ACLs

Create
- Stepper/Resources => Could do with a layout update - Redesign
  
  ACLs Creation Dialog Resources step
- Stepper/Resource identifier => BUG! Causes react crash when you try to select a resource identifier with no resources selected in the previous step
- Stepper/Rights => Could do with a layout update - Redesign
  
  ACLs Creation Dialog Rights step
Create from string => OK
Delete => Could perhaps be refactored so the user isn't flooded with so much text? - Redesign

ACLs Delete Dialog

Additional Context Please feel free to add any other context or screenshots about the feature request here. Or any other alternative you have considered to address this new feature.

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

May 10 '24 12:05 vichansson