Migrate Disks Across Datastores
Description
Disks should be able to be migrated from one datastore whether or not their DS_MAD is matching. The TM_MAD should be removed from Image DS Driver and it should just use the System DS TM_MAD for disk operations.
Design
The TM_MAD and TM_MAD_SYSTEM attributes will be removed from Image Datastore Attributes. The Transfer Manager should then check the target System Datastore for its TM_MAD attribute and use that driver.
tm/TransferManager.cc There are various sections in the Transfer Manager code which gathers the TM_MAD attribute to perform actions. Multiple of these will need to be adjusted to scan for the System Datastore’s TM_MAD attribute, rather than gathering it from the VM Disk Attributes.
vm/VirtualMachine.cc and vm/VirtualMachineDisk.cc There are multiple occurrences of the TM_MAD and TM_MAD_SYSTEM attributes being checked when deploying a virtual machine to determine the mode of deployment, these will also need to be adjusted for the changes in Datastore Attributes
There are a few other files which check the value of this TM_MAD or TM_MAD_SYSTEM attribute which may also need to be adjusted.
Progress Status
- [ ] Code committed
- [ ] Testing - QA
- [ ] Documentation (Release notes - resolved issues, compatibility, known issues)