M #-: Add IP Spoofing support for NIC_ALIAS

[rdiaz-on]

Add IP addresses of a NIC_ALIAS to the corresponding ipset if the parent NIC belongs to the "Bridged & Security Groups" network mode (fw) when a VM is instantiated or a NIC_ALIAS attached.

Signed-off-by: Ricardo Diaz [email protected]

[atodorov-storpool]

Hello. I am sorry to step in but I am a bit disappointed with this PR. IMHO this is not M #- as there are two bugs related to this: #3079 and #3354 and there is already developed pull request for #3354 . Looked at another side, besides implementing a solution that does not follow own guidelines (I mean https://github.com/OpenNebula/one/issues/3354#issuecomment-508806696) sound like downplaying contributor's work and is not nice. At least from my point of view.

Such behaviour and delaying PRs with years is highly discouraging to do project contributions.

Regards, Anton

[atodorov-storpool]

^ @rsmontero https://github.com/OpenNebula/one/pull/4764#issuecomment-645843393

[rsmontero]

Thanks @atodorov-storpool for this an other contributions to the project. As you see this PR is still in review and will include reference to the affected bugs.

As per the implementation this is indeed inspired by your PR, but re-written to improve its design and better fit in the driver. Also note that design decisions evolve with the code and need to consider its relation with other new components. Finally, we need to prioritize our available development resources, that unfortunately force us to delay some contributions. Please note that these decisions are not easy for us, and by not means imply that we underestimate your contributions.

Thanks again for your valuable contributions and hope you'll keep making them in the future.

[mzealey]

What is the status of this? It would be nice to have this included in opennebula...

[mzealey]

I have tested that this commit applies fine onto 5.12.0.3 and fixes the issue by adding/removing alias ips to the ipset.