OpenNoteBlockStudio icon indicating copy to clipboard operation
OpenNoteBlockStudio copied to clipboard

MIDI Input and Import is wrong

Open karl-police opened this issue 3 years ago • 5 comments

The notes from the MIDI input and import from F#5 or maybe everything, is like all shifted down by 1.

karl-police avatar Dec 22 '20 19:12 karl-police

Weird. I use a MIDI keyboard too but that doesn't happen to me, even when importing MIDIs. You could just select all the notes and then pitch them down a semitone, the notes should revert back to normal.

CubixL avatar Dec 23 '20 00:12 CubixL

Weird. I use a MIDI keyboard too but that doesn't happen to me, even when importing MIDIs. You could just select all the notes and then pitch them down a semitone, the notes should revert back to normal.

true but they split when "F" starts, so imagine there being two split up channels and how complicated it can become, well that only if you select "keep within octave range" only

but the rest is shifted down by one octave, therefore such is possible

karl-police avatar Dec 23 '20 01:12 karl-police

Issue is here:

https://github.com/HielkeMinecraft/OpenNoteBlockStudio/blob/cb8aa0212beb982f6a4a33337fa5ddd5533f745d/scripts/midi_input_set_key/midi_input_set_key.gml#L9

well that's one... there are more that do the same thing, idk why there are own ids but I think the actual midi ids should be used

karl-police avatar Dec 23 '20 15:12 karl-police

here is another one for the importer

https://github.com/HielkeMinecraft/OpenNoteBlockStudio/blob/cb8aa0212beb982f6a4a33337fa5ddd5533f745d/scripts/import_midi/import_midi.gml#L29

I kinda fixed the issue that the notes are being shifted down by debugging it and etc., but I believe there might be a few others, but that's maybe the piano only.

karl-police avatar Dec 23 '20 15:12 karl-police

I made this now aswell, since there wasn't a patch for it yet here for some reason.

https://github.com/HielkeMinecraft/OpenNoteBlockStudio/pull/227

karl-police avatar Jan 14 '21 10:01 karl-police