OpenNoteBlockStudio icon indicating copy to clipboard operation
OpenNoteBlockStudio copied to clipboard

MIDI Tempo change support

Open Andrew-J-Larson opened this issue 5 years ago • 6 comments

Is your feature request related to a problem? Please describe. Some MIDIs change tempo while mid song, or throughout the song, and importing them into Note Block Studio, they don't currently account for the tempo changes.

Describe the enhancement you'd like I know there's not going to be a perfect way to implement tempo changes, but there should still be some sort of tempo changes for songs that do change tempo if it's a noticeable type of change in tempo.

Additional context It shouldn't be too hard to find some MIDIs that do tempo changes in between the song.

Andrew-J-Larson avatar Apr 29 '20 04:04 Andrew-J-Larson

It is possible but will require a modification to the NBS format and the way datapack export quantizes the notes. It also won't work with schematic export unless a mod like tickratechanger is incorporated as a command.

But I do want to give it a go in the rewritten version

ShinkoNet avatar May 01 '20 06:05 ShinkoNet

Alrighty... and technically, there is a way without the tickrate changer, just it would require more or less spacing/repeaters for notes going at different tempos

Andrew-J-Larson avatar May 01 '20 08:05 Andrew-J-Larson

that would only work for very specific tempos, again, quantizing the notes as close to the timings as possible. Definitely painful to implement when a mod can just do it (on 1.12, where schematic support currently ends and the mod is avaliable on that version)

ShinkoNet avatar May 01 '20 08:05 ShinkoNet

It wouldn't be programming without some painful things to implement, now wouldn't it?

But yeah I feel you on that, wanting to cut corners where you can.

Andrew-J-Larson avatar May 01 '20 23:05 Andrew-J-Larson

Added as an experimental feature in 3.9.0.

OctoFlareDev avatar Aug 19 '21 07:08 OctoFlareDev

Where do I turn this Tempo change mid-song option?

gvnfc3 avatar May 03 '22 06:05 gvnfc3