OpenNoteBlockStudio icon indicating copy to clipboard operation
OpenNoteBlockStudio copied to clipboard

Feature Request: Keyboard animation for selected instrument

Open AlsoScratch opened this issue 6 years ago • 5 comments

I would like to see the keyboard animation for the instrument that is selected on the top than just the piano. Also, don't play the preview instrument sound when the track is playing.

AlsoScratch avatar Mar 20 '19 09:03 AlsoScratch

Very nice idea!

I dont really understand what you mean by this though:

don't play the preview instrument sound when the track is playing.

Can you please elaborate?

HielkeMinecraft avatar Mar 20 '19 12:03 HielkeMinecraft

Currently, when you choose the instrument, it makes the sound of that instrument so that I know how it sounds like. My idea is when the track is playing, you can still choose the instrument but that preview sound will not be heard as it will ruin the music.

AlsoScratch avatar Mar 20 '19 13:03 AlsoScratch

So, in instrument settings you can set which instrument will press the keyboard, by default only the harp will do this. I wanted to implement this idea because I thought you had no choice, but apparently you do!

I still think it's a nice thing to have, perhaps I'll add an option for it in the future.

HielkeMinecraft avatar Mar 21 '19 09:03 HielkeMinecraft

Just an addition, it does allows you to choose which instruments are shown on the keyboard but doesn't seem to save your preferences anywhere. So everytime you open the program, you have to manually configure everything again, which is a bit inconvenient (I record the keyboard to make music videos, so I tend to like them all enabled except for percussion). Would be nice if it got saved per song, or, if not that (as not to change the NBS specification and break backwards compatibility), at least saved along with the other settings.

Bentroen avatar Apr 13 '19 02:04 Bentroen

The piano keys could also get the color of the instrument when played, rather than all becoming yellow! This could create a really nice effect.

Bentroen avatar Apr 13 '19 02:04 Bentroen