OMSimulator icon indicating copy to clipboard operation
OMSimulator copied to clipboard

lib/OMSimulator directory contains duplicated files

Open adeas31 opened this issue 3 years ago • 14 comments

Description

After installing the latest OpenModelica nightly build I noticed that there are around 700 MB of files duplicated inside lib/OMSimulator folder.

Steps to reproduce the behavior

Install OpenModelica on Windows and take a look at lib/OMSimulator folder. The same files are also present in the bin folder as well.

Expected behavior

lib/OMSimulator should only contain the OMSimulator binaries.

Screenshots

image

Version and OS

  • Version: [Doesn't matter]
  • OS: [Win10, 64bit]

adeas31 avatar Feb 15 '21 16:02 adeas31

Unfortunately, we cannot just delete the duplicated files, because we depend on the path:

image

@AnHeuermann Do you see a way to solve this issue?

lochel avatar Feb 16 '21 10:02 lochel

We could add a bunch of symbolic links. Or change the paths if we compile OMSimulator from OpenModelica super project.

AnHeuermann avatar Feb 16 '21 10:02 AnHeuermann

Changing the path when compiling from the super project sounds like the right thing to do 👍

lochel avatar Feb 16 '21 10:02 lochel

Unfortunately, we cannot just delete the duplicated files, because we depend on the path:

Expected behavior

lib/OMSimulator should only contain the OMSimulator binaries.

For sure keep the binaries needed by OMSimulator but why there are folders for Qt plugins? I think the problem is you just make a copy of bin folder https://github.com/OpenModelica/OMSimulator/blob/master/src/OMSimulatorPython/CMakeLists.txt#L29

adeas31 avatar Feb 16 '21 12:02 adeas31

@adeas31 can this be closed or do we have to improve it further?

lochel avatar Feb 26 '21 09:02 lochel

Is better than before but would be nice to get rid of empty directories as well.

adeas31 avatar Feb 26 '21 10:02 adeas31

I didn't find a good solution to avoid the empty directories. @AnHeuermann do you have a idea for it?

lochel avatar Feb 26 '21 10:02 lochel

We can just call rm on them in the Makefile calling the CMake stuff. Not a pretty solution but should work.

AnHeuermann avatar Feb 26 '21 10:02 AnHeuermann

@AnHeuermann solution is not so bad.

adeas31 avatar Feb 26 '21 11:02 adeas31

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 04 '21 15:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 22 '21 18:08 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 09 '22 05:01 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 05:04 stale[bot]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

stale[bot] avatar Apr 27 '22 22:04 stale[bot]