OpenModelica
[BE] Added usage of failtrace debug flag
Welcome @kabdelhak. Thanks for your first contribution. Why do you want to hide the error message? Is the function supposed to fail and the test suite doesn't cover that case?
Thank you,
the commit was manly for me to get to used to the whole GIT-process. I stumpled upon it and asked Willi Braun about what that might be and we figured, that the function is allowed to fail and is not a crucial error. We thought it should just be shown if explicitly asked for.
Am 08.05.18 12:55 schrieb Lennart Ochel [email protected]:
Welcome @kabdelhak(https://github.com/kabdelhak). Thanks for your first contribution.
Why do you want to hide the error message? Is the function supposed to fail and the test suite doesn't cover that case?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(https://github.com/OpenModelica/OMCompiler/pull/2357#issuecomment-387364677), or mute the thread(https://github.com/notifications/unsubscribe-auth/AkRS_UoyP5cauOFho0Jx-He6e-9YEuvnks5twXmzgaJpZM4TQMiW).
@kabdelhak, @wibraun Do you have a model where this function actually fails? It should obviously fail for algorithms, when equations, and if equations. However, if it is not expected to reach one of these cases, then I would rather keep the error message explicit.
@lochel It depends on the usage of this function. If one would like to use it as a try and in failing case do something else, than the error message is totally misleading, especially for end-users. So I think it's okay to hide it. In the new removeSimpleEquations module is used like that and therefore I proposed to hide the error messages instead of having them in all related tests.
