SyMPC icon indicating copy to clipboard operation
SyMPC copied to clipboard

Add __str__ and __repr__ methods to ReplicatedSharedTensor

Open vdasu opened this issue 2 years ago • 5 comments

Description

Closes #230.

Affected Dependencies

N.A.

How has this been tested?

Python tests have passed successfully.

Checklist

vdasu avatar Apr 29 '22 17:04 vdasu

Could you run black formatter over the codebase?

gmuraru avatar May 01 '22 20:05 gmuraru

Could you run black formatter over the codebase?

I ran black but it seems to have changed a lot of files that I have not edited. Is this expected?

vdasu avatar May 02 '22 03:05 vdasu

Could you run black formatter over the codebase?

I ran black but it seems to have changed a lot of files that I have not edited. Is this expected?

Hmm...did you run the black version from the requirements file? It might be that you have another version (and sometimes black rules might change between versions)

gmuraru avatar May 02 '22 14:05 gmuraru

Could you run black formatter over the codebase?

I ran black but it seems to have changed a lot of files that I have not edited. Is this expected?

Hmm...did you run the black version from the requirements file? It might be that you have another version (and sometimes black rules might change between versions)

Yes, this seems to be this issue. I installed the black version in the requirements file and ran it again. Only one file which I did not change was reformatted this time. Does it look good?

vdasu avatar May 02 '22 16:05 vdasu

Could you run black formatter over the codebase?

I ran black but it seems to have changed a lot of files that I have not edited. Is this expected?

Hmm...did you run the black version from the requirements file? It might be that you have another version (and sometimes black rules might change between versions)

Yes, this seems to be this issue. I installed the black version in the requirements file and ran it again. Only one file which I did not change was reformatted this time. Does it look good?

Hmm..I think you need to run black by using the version you have installed in the local virtual environment. Something like: ./venv/bin/python -m black .

gmuraru avatar May 15 '22 12:05 gmuraru