PySyft icon indicating copy to clipboard operation
PySyft copied to clipboard

Show requesting domain (for DistributedProject as well as base Requests)

Open snwagh opened this issue 1 year ago • 2 comments

This changes the output to show the domain name at which the request was made. Tagging for PM review since I change the base object Request's repr. The output looks as follows (Requested on added):

Screenshot 2024-06-27 at 10 51 39 AM

The implementation may not be optimal since I am making the API call (I can take a look at the relation between _coll_repr_ and _repr_html_ to see if I can do this efficiently if that is promising).

snwagh avatar Jun 27 '24 14:06 snwagh

@itstauq Since the DistributedProjects uses the same objects inside it, I was wondering if this is a better fix as long as we run it by PM. It changes the Request object for the single projects too but it's just a change to the repr so not a conflicting change IMO.

snwagh avatar Jun 27 '24 18:06 snwagh

@itstauq To address your comment, added another commit that does not create a breaking change.

snwagh avatar Jun 28 '24 17:06 snwagh

Closing for now, we will move the domain information to Project code in this PR: https://github.com/OpenMined/PySyft/pull/8999

madhavajay avatar Jul 02 '24 04:07 madhavajay