PySyft icon indicating copy to clipboard operation
PySyft copied to clipboard

Static FL: /get-model is not protected

Open vvmnnnkv opened this issue 5 years ago • 1 comments

Description

FL model can be protected. In this case, /federated/get-model checks that the worker is authenticated. However, new /get-model endpoint (https://github.com/OpenMined/PyGrid/pull/609) is not protected. There seems to be need for 2 types of auth:

  1. Existing: worker authentication - for training the model, sending diff, etc.
  2. Missing: user authentication - for hosting the model, downloading the model, etc.

I think /get-model needs type 2 auth and should be available only to user who hosted the FL model.

Are you interested in working on this improvement yourself?

  • Yes, I am.

Additional Context

Add any other context or screenshots.

vvmnnnkv avatar Jul 16 '20 17:07 vvmnnnkv

This issue has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the stale label to unmark it. Otherwise, this will be closed in 7 days.

github-actions[bot] avatar Aug 16 '20 00:08 github-actions[bot]

0.2 is no longer supported.

madhavajay avatar Nov 17 '22 06:11 madhavajay