PyDP icon indicating copy to clipboard operation
PyDP copied to clipboard

gaussianmechanism function in sklearn_pipeline.py

Open SandeepJabez opened this issue 2 years ago • 5 comments

Description

I have written block of code for the function of gaussian mechanism

SandeepJabez avatar Jul 04 '22 07:07 SandeepJabez

LGTM! Tho I would suggest next time to make the commit bit by bit instead of all of it straight away. It will help to managed changes in codebase. Regardless, I see no issue with the implementation.

@chinmayshah99 Can we merge this soon?

grilhami avatar Jul 13 '22 16:07 grilhami

seems like there are conflicts. Please look into this.

chinmayshah99 avatar Jul 13 '22 17:07 chinmayshah99

@SandeepJabez there seems to be a bit more conflicts if you can look into it.

chinmayshah99 avatar Jul 17 '22 07:07 chinmayshah99

@SandeepJabez there seems to be a bit more conflicts if you can look into it.

yes, i was trying to fix, but ended up making more, I will look into them

SandeepJabez avatar Jul 17 '22 16:07 SandeepJabez

@chinmayshah99 @grilhami I have fixed the conflicts, kindly take a look.

SandeepJabez avatar Jul 20 '22 18:07 SandeepJabez