PyDP icon indicating copy to clipboard operation
PyDP copied to clipboard

Test Dockerfile installation

Open alejandrosame opened this issue 5 years ago • 6 comments

Description

Run tests on containers created through the officially provided Dockerfile.

Type of Test

  • [ ] Unit test (e.g. checking a loop, method, or function is working as intended)
  • [x] Integration test (e.g. checking if a certain group or set of functionality is working as intended)
  • [ ] Regression test (e.g. checking if by adding or removing a module of code allows other systems to continue to function as intended)
  • [ ] Stress test (e.g. checking to see how well a system performs under various situations, including heavy usage)
  • [ ] Performance test (e.g. checking to see how efficient a system is as performing the intended task)
  • [ ] Other...

Expected Behavior

Before publishing the image to DockerHub, me should run tests on a container built using our Dockerfile.

Additional Context

See https://github.com/OpenMined/PyDP/pull/267#pullrequestreview-474601461 for context.

alejandrosame avatar Sep 13 '20 12:09 alejandrosame

Can I take a look at this issue?

AbinavRavi avatar Nov 19 '20 21:11 AbinavRavi

Do you still need help with that?

bogomil avatar Jan 05 '21 10:01 bogomil

I have done the unit tests, I am not sure about how to do the other tests. If anyone can help me it would be useful

AbinavRavi avatar Jan 06 '21 09:01 AbinavRavi

I think this is a very good resource on how you could proceed. https://hackernoon.com/testing-strategies-for-docker-containers-f633e261e75a

I think the need here is to focus on integration tests only ^^

bogomil avatar Jan 06 '21 12:01 bogomil

Hi @AbinavRavi, if you are facing any issues, please reach out to us on slack in the #lib_pydp channel.

chinmayshah99 avatar Jan 06 '21 18:01 chinmayshah99

Can I take this issue?

liabifano avatar May 17 '21 17:05 liabifano