PipelineDP icon indicating copy to clipboard operation
PipelineDP copied to clipboard

Partition selection strategies

Open tohaowu opened this issue 2 years ago • 1 comments

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

tohaowu avatar Jun 03 '22 00:06 tohaowu

On testing:

Please

  1. Update this line create_truncated_geometric_partition_strategy -> create_partition_strategy (since we use it now) and please add tests with all strategies
  2. Could you please make test_aggregate_private_partition_selection_keep_everything test parameterized with all strategies

dvadym avatar Jun 10 '22 17:06 dvadym

Hello, this is related to https://github.com/OpenMined/PipelineDP/issues/281 , right? Is there anything else to implement here?

ricardocarvalhods avatar Jan 03 '23 14:01 ricardocarvalhods