PipelineDP
PipelineDP copied to clipboard
Partition selection strategies
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
- Describe the tests that you ran to verify your changes.
- Provide instructions so we can reproduce.
- List any relevant details for your test configuration.
Checklist
- [ ] I have followed the Contribution Guidelines and Code of Conduct
- [ ] I have commented my code following the OpenMined Styleguide
- [ ] I have labeled this PR with the relevant Type labels
- [ ] My changes are covered by tests
On testing:
Please
- Update this line create_truncated_geometric_partition_strategy -> create_partition_strategy (since we use it now) and please add tests with all strategies
- Could you please make test_aggregate_private_partition_selection_keep_everything test parameterized with all strategies
Hello, this is related to https://github.com/OpenMined/PipelineDP/issues/281 , right? Is there anything else to implement here?