Fix #1216 and the fallback theme

[Hanmac]

Description (*)

Done by Suggestion of https://github.com/OpenMage/magento-lts/issues/1216#issuecomment-1518591768

Related Pull Requests

• see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

• fixes OpenMage/magento-lts#1216

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [ ] All automated tests passed successfully (all builds are green)

[Hanmac]

just ignore sonar ;P

[Hanmac]

Kudos to @ericthehacker for the Original Version: https://github.com/ericthehacker/magento-themefallbackfix

[sonarqubecloud[bot]]

Quality Gate failed

Failed conditions
4 Security Hotspots
13.2% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[sonarqubecloud[bot]]

Quality Gate failed

Failed conditions
2 Security Hotspots
13.6% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[sreichel]

I'll test again as soon i am okay ....

My dog died last week and I need some days for my own. :(

[theroch]

Hey @sreichel,

I'm very sorry about your dog, I know he meant a lot to you. Take the time you need. We'll have a colleague at our company test the PR again with the current code.

[addison74]

My dog died last week and I need some days for my own. :(

@sreichel - I'm so sorry for your loss. I know how much this dog meant to you. I hope you get over it well. Take care of yourself.

[sreichel]

@Hanmac please update phpstan baseline to fix the conflict.

[sonarqubecloud[bot]]

Quality Gate failed

Failed conditions
4 Security Hotspots
13.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE