magento-lts Fix issue #4501 Exception noise from OAuth and REST (API2 )

Fix issue #4501 Exception noise from OAuth and REST (API2 )

Open kiatng opened this issue 9 months ago • 3 comments

Description (*)

See issue #4501. This PR added $shouldLog as an optional parameter in Mage_APi2_Exception, any code that extends it and overrides the constructor with the old signature would break.

Related Pull Requests

see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

fixes OpenMage/magento-lts#4501

Feb 22 '25 06:02 kiatng

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Feb 22 '25 06:02 sonarqubecloud[bot]

any code that extends it and overrides the constructor with the old signature would break.

https://github.com/OpenMage/magento-lts/issues/4501#issuecomment-2606224769

How about to add _criticalNotLoggable() method and a new exception?

Feb 25 '25 00:02 sreichel

any code that extends it and overrides the constructor with the old signature would break.

#4501 (comment)

How about to add _criticalNotLoggable() method and a new exception?

I have thought about new exception class. I am hesitant because I do not think there is any custom code that would extend it, if there is, it's easy to fix. This avoid adding more code.

Feb 28 '25 04:02 kiatng