filter_condition_callback in Mage_Adminhtml_Block_Promo_Quote_Edit_Tab_Coupons_Grid not working?

[Hanmac]

While checking some callbacks, I found this:

https://github.com/OpenMage/magento-lts/blob/031de28d0d31454cf9eee371f1b1a36901e647d2/app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Coupons/Grid.php#L85-L87

Doesn't this get ignored by this?

https://github.com/OpenMage/magento-lts/blob/031de28d0d31454cf9eee371f1b1a36901e647d2/app/code/core/Mage/Adminhtml/Block/Widget/Grid.php#L559-L560

Mage::getResourceModel('salesrule/coupon_collection') is not an instance of Mage_Adminhtml_Block_Promo_Quote_Edit_Tab_Coupons_Grid

[sreichel]

That change to Widget/Grid.php was part of 1.9.4.3 and has been discusses here.

[Hanmac]

That change to Widget/Grid.php was part of 1.9.4.3 and has been discusses here.

i know that the change happened long ago. I also understand the instanceof self check for security reasons.

Just that they forgot to change this part, because the callback can't happen anymore