magento-lts
magento-lts copied to clipboard
OpenMage
Fixed: Fixer.io endpoint for currency updates
I tested it, and it works, in our own project I used an overwrite to make sure we can keep collecting data.
Description (*)
Recently there were some changes, this is the new endpoint if anyone is also using it 💸 The platform had a few changes over the years, but I think recently an endpoint was deprecated, resulting in no more updating our currency information.
The format is the same, just the url is changed and apiKey was renamed to access_key in the params.
Related Pull Requests
I believe this solves: https://github.com/OpenMage/magento-lts/issues/3071
Fixed Issues (if relevant)
I believe this solves: https://github.com/OpenMage/magento-lts/issues/3071
Manual testing scenarios (*)
- set up a free account on fixer.io
- add 2 or more currencies
- go to System -> Manage Currencies -> Rates
- Press import
- Success
Questions or comments
First PR for Open Mage, keep it up!
if I open https://api.apilayer.com/fixer/latest on the browser it seems to work, is it not working at all for you?
is there any official info about the change?
@hirale what do you mean? that the currently used address is working fine?
Reads to me that apilayer is just a wrapper around the fixer api. So no change should be required.
https://apilayer.com/marketplace/fixer-api
@jankovandeventer why did you need it? did the flexer api not work for you?
@hirale what do you mean? that the currently used address is working fine?
the current one works fine.
For the time being I'll close this PR, @jankovandeventer feel free to reopen if you're ve the answers to the questions asked here :-)
Hi there, sorry for not responding sooner. When I use the credentials with the apilayer, I get an invalid authentication warning.
But I realize my mistake, the fixer.io credentials do not work on the apilayer so I had to move the subscription over to their new platform and now it works.
Sorry to bother :-)