magento-lts
magento-lts copied to clipboard
OpenMage
Make php7.3 minimum requirement
Description (*)
https://github.com/OpenMage/magento-lts/discussions/2402
Contribution checklist (*)
- [x] Pull request has a meaningful description of its purpose
- [x] All commits are accompanied by meaningful commit messages
- [x] All automated tests passed successfully (all builds are green)
- [x] Add yourself to contributors list
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 9901dc25. ± Comparison against base commit a002f37a.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
After this PR anyone is able to add code that is no longer compatible with 7.0, The automated syntax check for 7.0 should therefore be removed, shouldn't it or is it additive with syntax check for the newer versions? When/in which PR is the right place to do so?
once we change this should we release new major releases instead of minor?
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 14ceb0c6. ± Comparison against base commit a002f37a.
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 14ceb0c6. ± Comparison against base commit a002f37a.
once we change this should we release new major releases instead of minor?
I'm just here for code ... not versioning ... :rofl:
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 70792b4e. ± Comparison against base commit a002f37a.
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 70792b4e. ± Comparison against base commit a002f37a.
Given a version number MAJOR.MINOR.PATCH, increment the:
- MAJOR version when you make incompatible API changes
@fballiano So yes, technically such a change should be in a new major version, but it's not set on stone.
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 7fc8ed59. ± Comparison against base commit a002f37a.
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 7fc8ed59. ± Comparison against base commit a002f37a.
Let's wait a few days (since we just published a new release) and then I'm pro merging this one
why are these done on push and pull?
also, if we fix the conflict I'd approve it right away, it's time for this.
The other day I was reading an article in which the called Docker one of the IT wonders of the last 10 years. Those who already use Docker can take a step towards DDEV. I would encourage using DDEV for OpenMage testing. I would mention this link https://ddev.readthedocs.io/en/stable/users/quickstart/#openmagemagento-1 in README file.
I would also provide all the necessary steps for installation. In Windows OS, the mutagen_enable: true option is mandatory, otherwise running OpenMage it is as slow as on XAMPP/WAMP.
PS - please write DDEV in uppercase, not lowercase.
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 59f1fee4. ± Comparison against base commit a002f37a.
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 8b1f340e. ± Comparison against base commit c6917133.
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 8b1f340e. ± Comparison against base commit c6917133.
why are these done on push and pull?
I think one for newly created PR and one for added commits?!?
but it shouldn't be that way, the other PRs don't have all the workflow duplicated, one run per the full PR should be enough
Maybe because i've created the branch at OM repo? (Yea, i already changed it for other PRs)
Unit Test Results
1 files ±0 1 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 7 runs ±0 5 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
Results for commit 8a90b2bc. ± Comparison against base commit c6917133.