magento-lts icon indicating copy to clipboard operation
magento-lts copied to clipboard

Published 20 hours ago • verified publisher icon OpenMage

New admin theme: date fields to small

Open sreichel opened this issue 2 years ago • 2 comments

Preconditions (*)

  1. OM 19.4.17
  2. new admin theme

Steps to reproduce (*)

  1. got to catalog price rules

Expected result (*)

grid2

Actual result (*)

grid1

Change CSS min-width for .grid tr.filter .range div.date?

sreichel avatar Aug 10 '22 03:08 sreichel

The issue comes from this PR https://github.com/OpenMage/magento-lts/pull/2330. When I created it I didn't test the OpenMage theme, I never used it. The interesting part is that the values I set are the optimal ones, if they change they must be analyzed because I was at the limit with them.

In the future, I plan a review of all the grids in the Backend so that the types of columns are set in boxes.css and only when necessary they are set in Grids.php. But it will take time because there are around 160 files that need to be evaluated. I created a post related to this issue here https://github.com/OpenMage/magento-lts/issues/2239.

addison74 avatar Aug 10 '22 08:08 addison74

It is not the only visual issue, here's another one

screenshot

I tried to make changes to look good in the OpenMage theme but the arrangement in the Magento theme is broken.

At first glance I would say that the Magento theme and the OpenMage theme should not share the same boxes.css file.

addison74 avatar Aug 11 '22 21:08 addison74