magento-lts icon indicating copy to clipboard operation
magento-lts copied to clipboard

autoload without hiding errors

Open Flyingmana opened this issue 2 years ago • 3 comments

Description (*)

Related Pull Requests

alternative to https://github.com/OpenMage/magento-lts/pull/1817

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#1780

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All automated tests passed successfully (all builds are green)
  • [ ] Add yourself to contributors list

Flyingmana avatar Jul 10 '22 09:07 Flyingmana

This looks like a much better solution. Should you use the original return value?

return include $found;

Maybe the return value not used anywhere though...

justinbeaty avatar Jul 10 '22 12:07 justinbeaty

This looks like a much better solution. Should you use the original return value?

return include $found;

Maybe the return value not used anywhere though...

you are right, will add it again

Flyingmana avatar Jul 10 '22 13:07 Flyingmana

This is a simplest version of @Asfolny idea. I will test it!

luigifab avatar Jul 14 '22 20:07 luigifab