pyopenms_viz icon indicating copy to clipboard operation
pyopenms_viz copied to clipboard

Peptide Sequence Plotting. Solves issue #53

Open Ayushmaan06 opened this issue 9 months ago • 1 comments

Hey @jcharkow ! This PR addresses issue #53 by integrating the feature to plot peptide sequences with matched fragments into the Matplotlib backend interface. I have followed your instructions from the issue description. Also followed your instructions on the pr #62 .

Summary by CodeRabbit

  • New Features

    • Introduced a method for peptide sequence annotation in spectrum plots, with customizable display options (font size, colors, highlight) based on user configurations.
    • Enhanced clarity by indicating unsupported plotting modes for peptide sequences in specific backends.
  • Tests

    • Added tests to verify proper peptide sequence rendering on supported backends and ensure clear error handling for unsupported backends.

Ayushmaan06 avatar Mar 14 '25 12:03 Ayushmaan06

Walkthrough

The changes introduce peptide sequence plotting functionality into the project. A new method, plot_peptide_sequence, has been added in various plotting classes to handle peptide sequence annotations. In the abstract SpectrumPlot class, the method is declared and conditionally invoked based on configuration settings from an enhanced SpectrumConfig. For the Matplotlib backend, an actual implementation renders text and annotations, while for the Bokeh and Plotly backends, the method raises a NotImplementedError. Additional tests have been added to ensure the correct behavior in both supported and unsupported backends.

Changes

File(s) Change Summary
pyopenms_viz/_bokeh/core.py, pyopenms_viz/_plotly/core.py Add plot_peptide_sequence method that raises a NotImplementedError for unsupported peptide sequence plotting in these backends.
pyopenms_viz/_config.py Augment SpectrumConfig with new fields: display_peptide_sequence, peptide_sequence, matched_fragments to support peptide sequence plotting.
pyopenms_viz/_core.py Introduce an abstract plot_peptide_sequence method in SpectrumPlot and update the plot method to call it conditionally based on configuration settings.
pyopenms_viz/_matplotlib/core.py Implement plot_peptide_sequence to render peptide sequence annotations using Matplotlib for visualizing matched fragments.
test/test_chromatogram.py Add configuration for Matplotlib backend to a non-interactive mode to avoid display issues.
test/test_spectrum.py Add test_spectrum_peptide_sequence_matplotlib to validate plotting of peptide sequences using Matplotlib, including configuration for the Matplotlib backend, and test_spectrum_peptide_sequence_unsupported to check for NotImplementedError in unsupported backends.

Sequence Diagram(s)

sequenceDiagram
    participant S as SpectrumPlot
    participant C as SpectrumConfig
    participant M as MATPLOTLIBSpectrumPlot
    participant U as UnsupportedBackend

    S->>C: Check if display_peptide_sequence is enabled
    alt Enabled (Matplotlib)
        S->>M: Call plot_peptide_sequence(peptide_sequence, matched_fragments)
        M->>M: Render text and annotations via ax.text/annotate
    else Unsupported
        S->>U: Call plot_peptide_sequence
        U-->>S: Raise NotImplementedError
    end

Possibly related issues

  • OpenMS/pyopenms_viz#53: The changes in the main issue are directly related to the modifications proposed in the retrieved issue, as both involve the addition of a plot_peptide_sequence method in the SpectrumPlot class and its integration into the plotting framework, along with updates to the SpectrumConfig class for peptide sequence handling.

Poem

I'm a bunny coding through the night,
Hopping to changes, feeling just right.
Peptide sequences now waltz on the screen,
With Matplotlib magic, a joyful scene.
Bokeh and Plotly say, "Not yet, it seems!"
🐇✨

[!TIP]

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments. - To enable this feature, set early_access to true under in the settings.
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 14 '25 12:03 coderabbitai[bot]