autowrap icon indicating copy to clipboard operation
autowrap copied to clipboard

Published 20 hours ago • verified publisher icon OpenMS

Feature/map output

Open erik-whiting opened this issue 2 years ago • 4 comments

This is in support of issue #143, let me know if this is what you're looking for. Thanks!

PS, there are some refactors in this PR

erik-whiting avatar Jul 02 '22 21:07 erik-whiting

looks good from my side. Maybe wait for Julianus to give some feedback. Also to decide if we should already bump up the autowrap version.

timosachsenberg avatar Jul 04 '22 13:07 timosachsenberg

@jpfeuffer it's ready for another look whenever you have time

erik-whiting avatar Jul 13 '22 00:07 erik-whiting

Hey @jpfeuffer, I implemented the approach you suggested for building the cython code for output_provider. This approach reduced a lot of redundancy. As a result, the method is significantly shorter.

Let me know if you want me to change anything. If you merge this, I think I'll use it as the base for future refactoring in that same file, should make it a lot smaller and easier to understand. Lmk!

erik-whiting avatar Jul 17 '22 19:07 erik-whiting

Yes, a bit better. Still not quite completely refactored IMO: Bildschirmfoto 2022-07-25 um 15 34 20

This applies to other if-cases and maybe more variables in the template code.

jpfeuffer avatar Jul 25 '22 13:07 jpfeuffer