autowrap icon indicating copy to clipboard operation
autowrap copied to clipboard

Published 20 hours ago • verified publisher icon OpenMS

Codestyle

Open jpfeuffer opened this issue 3 years ago • 3 comments
trafficstars

  • Type hints
  • Auto lint (flake, black, prettier,..?)
  • Documentation
  • require py 3.6 and use f-strings for all the template code. Maybe even use a templating library if we introduce more recursion to make it readable.

jpfeuffer avatar Mar 28 '22 23:03 jpfeuffer

Hey @jpfeuffer can I take the "Auto lint" part of this issue ahead of GSoC officially starting? I'd use black and maybe even pre-commit if you think that'd be useful (Biopython uses pre-commit but that project is much larger).

erik-whiting avatar May 26 '22 00:05 erik-whiting

Hi @erik-whiting Yes! That would be great. Black is fine. For precommits, it would be great if you could put a hook in the repo which is not automatically installed so developers can choose if they want that in their GitHub cycle. Do you know what I mean?

jpfeuffer avatar May 26 '22 04:05 jpfeuffer

Made a PR here. I would've requested you as reviewer but I didn't see that option. Let me know if you want me to change anything!

erik-whiting avatar May 26 '22 05:05 erik-whiting