autowrap icon indicating copy to clipboard operation
autowrap copied to clipboard
verified publisher icon OpenMS

Implement all operators

Open jpfeuffer opened this issue 3 years ago • 10 comments

at least - missing

jpfeuffer avatar Mar 13 '22 22:03 jpfeuffer

see https://github.com/OpenMS/OpenMS/issues/5914

timosachsenberg avatar Mar 14 '22 07:03 timosachsenberg

@jpfeuffer how difficult would this be? Could this be an entry level task for new devs?

timosachsenberg avatar Mar 14 '22 07:03 timosachsenberg

Without further checking, it should be copying two lines and write a test.

jpfeuffer avatar Mar 14 '22 08:03 jpfeuffer

Perfect let’s use that for GSoC?

timosachsenberg avatar Mar 14 '22 09:03 timosachsenberg

If someone does it, yes. But I would not wait forever.

jpfeuffer avatar Mar 14 '22 09:03 jpfeuffer

yeah basically as qualification task

timosachsenberg avatar Mar 14 '22 09:03 timosachsenberg

probably needs to be added here: https://github.com/OpenMS/autowrap/blob/8645068034085f761f8e7ea1e65f79223fd49cf3/autowrap/CodeGenerator.py#L673-L700

timosachsenberg avatar Mar 23 '22 18:03 timosachsenberg

Starting work on this!

I will add the '-' operator as a start

satvik-tha-god avatar Mar 25 '22 07:03 satvik-tha-god

@satvik-tha-god can add more operators like '-=' and '*=' your views @jpfeuffer

Arraxx avatar Mar 28 '22 07:03 Arraxx

Hey I made a PR for adding % and %= for this issue here. If the PR looks good to y'all, I think this issue can probably get closed out. lmk what y'all think!

erik-whiting avatar Jun 26 '22 05:06 erik-whiting