OpenMS icon indicating copy to clipboard operation
OpenMS copied to clipboard

Apply fix from https://github.com/apache/arrow/pull/35323 to handle visual-C++ dependency

Open poshul opened this issue 9 months ago • 3 comments

See https://github.com/apache/arrow/issues/44855 for details on the original issue.

poshul avatar Mar 19 '25 14:03 poshul

@poshul Apologies, I wasn’t assigned to this issue, but I was eager to contribute and went ahead with the PR. Please take a look and let me know if it resolves the issue correctly.

VanshChitransh avatar Mar 20 '25 18:03 VanshChitransh

Yeah, I think you should have asked first.

I think/hope @poshul meant the delvewheel solution.

If we really go the static runtime solution we need make it a) configurable, b) use modern CMake (MSVC_RUNTIME_LIBRARY variable), c) only enable for pyopenms and only on GitHub Actions, d) not make it dependent on Boost (not sure why you are doing this)

jpfeuffer avatar Mar 20 '25 19:03 jpfeuffer

Hi @jpfeuffer

Thanks for the feedback, and I completely understand your concerns. Apologies again for not consulting beforehand—I got excited to contribute and should have coordinated better.

Regarding the points you raised:

You're right, I did approach it with a static runtime mindset based on the original issue and similar patterns I’ve seen elsewhere. I’ll look into making this configurable and scoped only to pyopenms during GitHub Actions builds. I’ll also refactor it to use the MSVC_RUNTIME_LIBRARY variable to align with modern CMake practices. The Boost dependency was unintentional, I’ll decouple it as suggested. I’ll rework the PR accordingly and share an update soon. Appreciate your guidance on this!

VanshChitransh avatar Mar 21 '25 04:03 VanshChitransh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 03 '25 02:10 github-actions[bot]

Still has to be done

jpfeuffer avatar Oct 03 '25 08:10 jpfeuffer