OpenMS icon indicating copy to clipboard operation
OpenMS copied to clipboard

Update containerdeploy.yml to match Release/

Open poshul opened this issue 1 year ago • 2 comments

User description

Trigger container deploy on release branches including /. Update action versions for new node.js

Checklist

  • [ ] Make sure that you are listed in the AUTHORS file
  • [ ] Add relevant changes and new features to the CHANGELOG file
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Updated or added python bindings for changed or new classes (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI

Click to expand If your PR is failing you can check out
  • The details of the action statuses at the end of the PR or the "Checks" tab.
  • http://cdash.openms.de/index.php?project=OpenMS and look for your PR. Use the "Show filters" capability on the top right to search for your PR number. If you click in the column that lists the failed tests you will get detailed error messages.

Advanced commands (admins / reviewer only)

Click to expand
  • /reformat (experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.
  • setting the label "NoJenkins" will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)
  • commenting with rebuild jenkins will retrigger Jenkins-based CI builds

:warning: Note: Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).


PR Type

enhancement, configuration changes


Description

  • Enhanced the container deployment workflow to trigger on release branches with the pattern "Release/*".
  • Updated the versions of GitHub Actions used in the workflow, including actions/checkout, docker/login-action, and docker/build-push-action.
  • Improved compatibility with new node.js requirements by updating action versions.

Changes walkthrough 📝

Relevant files
Configuration changes
containerdeploy.yml
Update container deploy workflow for release branches and action
versions

.github/workflows/containerdeploy.yml

  • Added support for triggering container deploy on release branches with
    pattern "Release/*".
  • Updated GitHub Actions versions for checkout, login-action, and
    build-push-action.
  • Enhanced the workflow to accommodate new node.js requirements.
  • +9/-8     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    poshul avatar Oct 16 '24 08:10 poshul

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    github-actions[bot] avatar Oct 16 '24 08:10 github-actions[bot]

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    github-actions[bot] avatar Oct 16 '24 08:10 github-actions[bot]

    for whatever reason I just can't get cmake to recognize that OpenMP exists on Mac: -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES) -- Could NOT find OpenMP (missing: OpenMP_CXX_FOUND CXX) @jpfeuffer any suggestions?

    poshul avatar Nov 04 '24 13:11 poshul

    Where do you see this? the last run of this was 3 weeks ago and the CDash logs are expired.

    jpfeuffer avatar Nov 04 '24 13:11 jpfeuffer