OpenMS Update COMET to the latest version

Comet has released the latest version (2024.01.1). We should update Comet in OpenMS.

Sep 19 '24 08:09 MaLLLiYA

@timosachsenberg as we discussed @MaLLLiYA will be trying now to update COMET to the latest version. Can you help us to understand what are the steps?

@MaLLLiYA In the meantime, try to see what new parameters in COMET needs to be added to the current COMETAdapter.

Sep 19 '24 08:09 ypriverol

@cbielow made an update to the adapter as far as I know to support Comet 2024.01 rev. 0 : https://github.com/OpenMS/OpenMS/commit/4167da732a3f8c8def288c6af52e9f5e9eef420c

Comet binaries in the https://github.com/OpenMS/THIRDPARTY repository still need to be updated. Here is an example how it was done for Sage: https://github.com/OpenMS/THIRDPARTY/pull/109

And we need to check what changed since then here: https://uwpr.github.io/Comet/releases/release_202401.html If there were new or changed parameters we need to adapt the CometAdapter

Sep 19 '24 08:09 timosachsenberg

https://github.com/OpenMS/THIRDPARTY/commit/306efdbd08266e70769a9221eccb94538cbd9954

Aug 29 '25 09:08 jpfeuffer