OpenMS icon indicating copy to clipboard operation
OpenMS copied to clipboard

Add more tests for FLASHDeconv

Open bernt-matthias opened this issue 2 years ago • 15 comments
trafficstars

testing

  • -out_spec, -out_topFD, -out_topFD_feature
  • mzML with MS2 only, and MS1-3

Is there nowadays a way to test the written tsv file contents .. and maybe check if certain files are absent?

Was just trying to understand how this works and wondering how to implement this for the Galaxy tool.

Probably I will hardcode -out_spec level1.tsv level2.tsv level3.tsv (level3.tsv will be absent if there is no level3 .. and in the worst case there is an empty tsv for mzML containing only level 2).

Description

Checklist

  • [ ] Make sure that you are listed in the AUTHORS file
  • [ ] Add relevant changes and new features to the CHANGELOG file
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Updated or added python bindings for changed or new classes (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI

Click to expand If your PR is failing you can check out
  • The details of the action statuses at the end of the PR or the "Checks" tab.
  • http://cdash.openms.de/index.php?project=OpenMS and look for your PR. Use the "Show filters" capability on the top right to search for your PR number. If you click in the column that lists the failed tests you will get detailed error messages.

Advanced commands (admins / reviewer only)

Click to expand
  • /reformat (experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.
  • setting the label "NoJenkins" will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)
  • commenting with rebuild jenkins will retrigger Jenkins-based CI builds

:warning: Note: Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

bernt-matthias avatar Oct 27 '23 13:10 bernt-matthias