Aviary icon indicating copy to clipboard operation
Aviary copied to clipboard

"average diameter" variables misleadingly named for FLOPS-based analysis

Open jkirk5 opened this issue 1 year ago • 0 comments

Desired capability or behavior.

Aircraft.Fuselage.AVG_DIAMETER, when used by the FLOPS-based geometry and weight regressions, is not a true average diameter - it is actually a hypothetical diameter that averages maximum height and maximum width (the actual shaping of the fuselage is implicit in all of the regressions that use this parameter). This may be unclear to users and could cause problems when overriding this value with values from external codes (like openVSP).

Renaming to Aircraft.Fuselage.REFERENCE_DIAMETER would avoid mistaken assumptions of this variable on the FLOPS side, but could introduce new ambiguity on the GASP side. A possible solution is add this as a new variable for FLOPS to use.

More documentation (both in-code and as part of the FLOPS geometry section of the docs) is needed regardless.

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

jkirk5 avatar Feb 23 '24 19:02 jkirk5