open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `american-dj/starship`

Open FloEdelmann opened this issue 2 months ago • 2 comments

  • Add fixture american-dj/starship

Fixture warnings / errors

  • american-dj/starship
    • ❌ Mode '120ch DMX' should have 120 channels according to its name but actually has 36.
    • ❌ Mode '120ch DMX' should have 120 channels according to its shortName but actually has 36.
    • ⚠️ Unused channel(s): tilt 7, tilt 7 fine, tilt 8, tilt 8 fine
    • ⚠️ Category 'Color Changer' suggested since there are ColorPreset or ColorIntensity capabilities or Color wheel slots.

Thank you aztek musik!

FloEdelmann avatar Oct 24 '25 15:10 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

american-dj / starship: d-light / attributes-correctness
  • ❌ american-dj/starship-120ch DMX.xmlError parsing XML: Duplicate parameter name: FOCUS/TILT,Duplicate parameter name: FOCUS/TILT,Duplicate parameter name: FOCUS/TILT,Duplicate parameter name: FOCUS/TILT,Duplicate parameter name: FOCUS/TILT
✔️ american-dj / starship: dmxcontrol3 / channel-numbers
  • ✔️ american-dj-starship-120ch-DMX.xml
✔️ american-dj / starship: dragonframe / json-schema-conformity
  • ✔️ american-dj/starship.json
  • ✔️ manufacturers.json
✔️ american-dj / starship: millumin / json-schema-conformity
  • ✔️ american-dj/starship.json
american-dj / starship: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/American-DJ-Starship.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
american-dj / starship: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/American-DJ-Starship.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

github-actions[bot] avatar Oct 24 '25 15:10 github-actions[bot]

This fixture's documentation shows 22-channel and 120-channel modes. This mapping has only a 36-channel mode (labelled 120-channel). So it's rather incomplete.

Obviously, these big modes have a lot of repetition, so this should use template channels in OFL, too.

This isn't a very complex fixture, if someone wanted to take the time to finish it.

kengruven avatar Oct 24 '25 15:10 kengruven